Hi Laszlo, I suppose that we should create PRs against both master and release90 branches if they need that change. Or first of all, we should create a PR against the master branch. Then we should backport it to the release90 branch.
I actually created PRs: https://github.com/apache/incubator-netbeans/pull/566 This is Jan's PR: https://github.com/apache/incubator-netbeans/pull/565 Thanks, Junichi On Mon, Jun 4, 2018 at 5:32 AM Laszlo Kishalmi <[email protected]> wrote: > > Hi all! > > What shall be the PR creation strategy regarding release90. I'm having a > real harmless NPE patch > https://github.com/apache/incubator-netbeans/pull/574 > > Right now I made the PR against the release90 branch. Shall I do it > against the master as well? > > BTW what is our branch handling strategy for release? We branch, alter > the required changes (branding, etc.), and cherry pick from master? > > In this case how shall we decide which PR shall go to the release branch > as well? > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
