Gj, Yes, I agree. I have read the instructions and I don't see anything that's unclear about the pull request. I don't think a YouTube clip is necessary but I know if you did one it would be done well. :)
I was mainly thinking about style and project organization. More of if the code is to be accepted, what might get it more inline with what's expected. I have looked at the project some but not enough to say it was correct to create a "macos" directory for example. I have created the JIRA ticket but I will poke around a bit more as time permits before I submit the pull request. I think this particular enhancement, if one can call it that, is probably a good way for me to learn a bit about the overall organization. Regards, Carl On Sun, Aug 12, 2018 at 10:32 AM Geertjan Wielenga <[email protected]> wrote: > I can make a YouTube clip to explain how to provide pull requests to Apache > NetBeans, however it wouldn’t be different to doing a pull request for any > other project via Git. > > Gj > > On Sunday, August 12, 2018, Carl Mosca <[email protected]> wrote: > > > Thank you Sebastian. I appreciate the feedback. > > > > I imagine someone can provide a few pointers on where I located the > > Info.plist file, my use (and lack of) use of properties, and the final > > location of the pkg file. > > > > Hopefully I will learn about the pull request process. > > > > Carl > > > > On Sun, Aug 12, 2018 at 8:21 AM [email protected] < > > [email protected]> wrote: > > > > > I've tried it on my Mac and it works very well, i would appreciate if > > > your work will be merged. Its very useful for further releases :) > > > > > > Sebastian > > > > > > > > > Am 12.08.18 um 12:07 schrieb Carl Mosca: > > > > I guess I forgot to include that the location of the pkg file should > > > > be nbbuild/MacOS > > > > after the build completes. > > > > > > > > > > > > Carl > > > > > > > > On Sun, Aug 12, 2018 at 3:04 AM Carl Mosca <[email protected]> > > wrote: > > > > > > > >> If you're willing to try the package installer, clone this fork: > > > >> https://github.com/carljmosca/incubator-netbeans on a Mac. > > > >> > > > >> Follow the setup for the build requirements then run "ant > > package-macos" > > > >> > > > >> This should do a build followed by the creation of a Mac package > > > installer. > > > >> > > > >> On Fri, Aug 10, 2018 at 2:36 AM Geertjan Wielenga > > > >> <[email protected]> wrote: > > > >> > > > >>> Yes, if you can create installers, that would be wonderful! > > > >>> > > > >>> I’ve seen about three different Mac OSX installers around so far. > > > >>> > > > >>> Please don’t wait, create installers if you can, and write back > here > > > with > > > >>> instructions when you’ve done so. > > > >>> > > > >>> Gj > > > >>> > > > >>> On Wednesday, August 8, 2018, Carl Mosca <[email protected]> > > wrote: > > > >>> > > > >>>> I am wondering if anyone is working on these. I would like to help > > if > > > >>>> needed. > > > >>>> > > > >> > > > >> -- > > > >> Carl J. Mosca > > > >> > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [email protected] > > > For additional commands, e-mail: > [email protected] > > > > > > For further information about the NetBeans mailing lists, visit: > > > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > > > > > > > > > > > > > > -- > > Carl J. Mosca > > > -- Carl J. Mosca
