What is the process / criteria for approving a PR and what is the process / criteria for closing a PR?
On the one hand everyone is encouraging people to contribute, on another hand you are suggesting to throw away contributions. Publish some PR submitter guidelines saying what people need to do to get a PR approved and what to do if their particular reviewer doesnt want to commit the changes and what to do if you have no comments at all on your PR. Once the process is clear then auto closing can be a valid action because the PR submitter is aware that this will happen. On Fri, 17 Aug 2018 07:35 Jaroslav Tulach, <[email protected]> wrote: > Dne Pá 17. srpna 2018 06:30:28, Peter Steele napsal(a): > > So my thoughts on this would be to decide on a more formal PR approach > and > > apply it to this situation > > Great, that is what I am calling for! > > Let's automatically close PRs that are silent for 60 days and more. > > Simple. Formal. Well defined. Easy to understand and implement approach. > -jt > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > For further information about the NetBeans mailing lists, visit: > https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists > > > >
