Thanks for the patch!
As Travis reports it back good, I'm going to merge it and cherry pick
that to release100. I'm going to do the comparison as well.
I'm on holiday this week. I hope my wife approves to do these things. ;)
On 11/21/18 9:37 AM, Jan Lahoda wrote:
Another attempt:
https://github.com/apache/incubator-netbeans/pull/1026
But there is one more check I'd like to do (compare the source zip from vc3
with the source zip produced after this patch) which I cannot do right now.
Jan
On Wed, Nov 21, 2018 at 5:55 PM Jan Lahoda <[email protected]> wrote:
I am afraid the patch has the same problem as the Geertjan's one (i.e.it
won't compile). I am trying to work on a patch that would fix this more
appropriatelly, although I am on a_very_ bad internet connection.
Jan
On Wed, Nov 21, 2018 at 5:43 PM Laszlo Kishalmi <[email protected]>
wrote:
I'm adding a PR to remove the jars from the master branch and going to
cherry pick it to release100
What should happen with the autoupdate test data?
./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/dummy-signed-twice.jar
./platform/autoupdate.services/test/unit/src/org/netbeans/api/autoupdate/data/dummy-signed.jar
They are containing not just signature but a Dummy main class as well.
On 11/21/18 8:25 AM, Emilian Bold wrote:
The JARs were added as part of the commit
3dfe01225c66a7b6438801621b4d111f946e64b5 which moved whole folders
around and somehow picked up some local non-commited JARs.
The Jenkins job is fine.
--emi
On Wed, Nov 21, 2018 at 5:28 PM Laszlo Kishalmi
<[email protected]> wrote:
I've checked the release Jenkins job. It seems the clean workspace
option has not been checked there or any other real attempt to clean it
before packing the sources.
I've enabled the clean workspace option and rerun the build. Going to
check the output. We either got lucky with 9.0 that it run on a clean
WS
or we actually delivered the same jars.
As of the mentioned no header source code those are specially crafted
test data files which could be an exception.
On 11/21/18 2:45 AM, Geertjan Wielenga wrote:
Hi all,
In the IPMC vote thread, JARs have been discovered in the platform
cluster.
Apache releases source code only so this blocks our release.
I checked on Apache NetBeans GitHub, and, yes, I see a junit4 JAR, for
example, as indicated in the IPMC vote thread.
How did these get there, were they there for the previous release, how
could we have released with those there, Justin would have picked
them up
too.
We’ll need to remove these, make vc4, vote on vc4 here, then IPMC vote
again. I estimate two weeks will be needed for voting from the point
the
vc4 is created.
If anyone (mentors, for example) have a better solution, please say
so.
Gj
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail:
[email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
