Hi Peter, Upon brief review, the PR looks correct to me. However, I think you will need to add the license headers back to the modified files. I’ve left a comment in the PR.
Thanks! Josh Juneau http://jj-blogger.blogspot.com https://www.apress.com/index.php/author/author/view/id/1866 > On Jan 1, 2019, at 8:50 AM, Peter Cheung <[email protected]> wrote: > > Hi > Anybody can tell me i did correctly or not? > > https://github.com/apache/incubator-netbeans/pull/1065 > > > > Thanks > From Peter
