Dne středa 23. ledna 2019 14:03:48 CET, Mark Phipps napsal(a): > Hi Folks, > > I created the pr below, but as it includes an API change, the build > fails (as it did on my local copy - see output below) due to an invalid > API signature? > > https://github.com/apache/incubator-netbeans/pull/1095 > > How does one fix that?
The easiest way is to not make *incompatible* API changes. -jt PS: The check has been integrated by https://github.com/apache/incubator-netbeans/pull/1064 PPS: Is it a shameless promo of my website and book? http://apidesign.org > sigtest check: platform/openide.windows; cnb: org-openide-windows; > email: api-chan...@netbeans.org; type: check > check-sigtest: > /home/mark/Development/github/incubator-netbeans/platform/openide.windows/bu > ild/test/sigtest/results/org.openide.windows Packages: org.openide.windows.* > email: api-chan...@netbeans.org > SignatureTest report > Base version: 6.79.1 > Tested version: 6.80 > Check mode: bin [throws removed] > Constant checking: on > Class org.openide.windows.Mode > "E2.1 - Interface method added" : method public abstract > java.lang.String org.openide.windows.Mode.toXml() > Class org.openide.windows.WindowManager > "E5.2 - Adding abstract methods" : method public abstract void > org.openide.windows.WindowManager.updateModeContraintsFromXml(java.lang.Stri > ng) "E5.2 - Adding abstract methods" : method public abstract boolean > org.openide.windows.WindowManager.removeMode(org.openide.windows.Mode) > "E5.2 - Adding abstract methods" : method public abstract void > org.openide.windows.WindowManager.createModeFromXml(java.lang.String) > /home/mark/Development/github/incubator-netbeans/platform/openide.windows/bu > ild/test/sigtest/results/org-openide-windows.xml: 1 failures in > /home/mark/Development/github/incubator-netbeans/platform/openide.windows/nb > project/org-openide-windows.sig > /home/mark/Development/github/incubator-netbeans/nbbuild/templates/projecti > zed.xml:768: Signature tests return code is wrong (1), check the messages > above BUILD FAILED (total time: 0 seconds) > > > > *Mark Phipps |***Front Office Development Manager > *Sucden Financial Limited |*Plantation Place South***|***60 Great Tower > Street***| *London EC3R 5AZ > > *Telephone (DDI): *+44 (0)20 3207 5140* | Switchboard:***+44 (0)20 3207 5000 > *Email: *mark.phi...@sucfin.com <mailto:mark.phi...@sucfin.com> | > *Website:* www.sucdenfinancial.com <http://www.sucdenfinancial.com> > > > Description: signature20170705.jpg <http://www.sucdenfinancial.com/en> > > Twitter <https://twitter.com/SucdenFinancial>| LinkedIn > <https://www.linkedin.com/company/sucden-financial-limited> > > www.sucdenfinancial.com > > Sucden Financial Limited, Plantation Place South, 60 Great Tower Street, > London EC3R 5AZ Telephone +44 203 207 5000 > > Registered in England no. 1095841 > VAT registration no. GB 446 9061 33 > > Authorised and Regulated by the Financial Conduct Authority (FCA) and > entered in the FCA register under no. 114239 > > This email, including any files transmitted with it, is confidential and may > be privileged. It may be read, copied and used only by the intended > recipient. If you are not the intended recipient of this message, please > notify postmas...@sucfin.com immediately and delete it from your computer > system. > > We believe, but do not warrant, that this email and its attachments are > virus-free, but you should check. > > Sucden Financial Limited may monitor traffic data of both business and > personal emails. By replying to this email, you consent to Sucden Financial > 's monitoring the content of any emails you send to or receive from Sucden > Financial . Sucden Financial is not liable for any opinions expressed by > the sender where this is a non-business email. > > The contents of this e-mail do not constitute advice and should not be > regarded as a recommendation to buy, sell or otherwise deal with any > particular investment. Where any trade ideas are made by an employee of > Sucden Financial in an electronic communication, these are made > incidentally to your dealing relationship with us and are provided solely > to enable you to make your own investment decisions and do not amount to > advice. Please note that the employee may have had many, varied trade ideas > over the past 12 months, including contrary ideas. Any trade ideas are > solely based on the employee’s market knowledge and experience and may not > be tailored to your specific circumstances or investment objectives. Please > contact the employee who made the trade idea if you would like to see any > of his/her trade ideas made in the previous 12 months for comparative > purposes. Please visit our website to view our full risk warnings and > disclaimers: www.sucdenfinancial.com. > > This message has been scanned for viruses by Mimecast. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@netbeans.incubator.apache.org For additional commands, e-mail: dev-h...@netbeans.incubator.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
