Github user danbress commented on the pull request:
https://github.com/apache/nifi/pull/80#issuecomment-136828624
Yu, this looks great. Thanks again for sticking with it and contributing.
I made one comment inline.
I have one other comment that I'd like to get others feedback on:
This processor attempts to delete data from Amazon S3. I could see there
being a case for three scenarios, and three relationships out of the processor
1) the data is found in S3, and deleted(success)
2) the data is not found in S3, and therefore not deleted(not found)
3) there was some issue communicating with S3 and the object could not be
deleted(failure)
Basically, you would be adding a "not found" relationship, and routing
FlowFiles there when you they are not found in S3 before you attempt to delete
them. The reason being, you allow the user of your processor the opportunity
to treat "not found" situations differently from "failure" situations.
I tried to find other cases like this in the NiFi processor marketplace,
but I couldn't.
(https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/sqs/DeleteSQS.java)
is the only "delete" processor I see, and it doesn't behave the way I am
describing.
@markap14 @mcgilman @joewitt toughts
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
