+1

Sent from my iPhone

> On Sep 15, 2015, at 3:11 PM, Rick Braddy <[email protected]> wrote:
>
> +1 Release this package as nifi-0.3.0
> --------------------------------------------
> - KEYS file in source package only contains 4 signers, official release dist 
> has 6 signers: https://dist.apache.org/repos/dist/release/nifi/KEYS
>   (looks like Aldrin and Mark Payne were added to release keys but missing 
> from source package KEYS file if I'm reading gpg -k right)
>   This is a minor detail, but seemed worth noting - recommend addressing in 
> next release.
>
> - Code is not signed with a trusted signature (another minor but noteworthy 
> issue - recommend resolving in next release)
>
>     gpg: Signature made Mon 14 Sep 2015 08:49:09 PM CDT using RSA key ID 
> 432AEE37
>     gpg: Good signature from "Matt Gilman (CODE SIGNING KEY) 
> <[email protected]>"
>     gpg: WARNING: This key is not certified with a trusted signature!
>     gpg:          There is no indication that the signature belongs to the 
> owner.
>     Primary key fingerprint: 507A 2050 1632 8841 C4BA  C9EE DF61 EC19 432A 
> EE37
>
> + MD5 and SHA1 sigs match
> + source from zip file build was successful, all unit test passed
> + good README, LICENSE, NOTICE, DISCLAIMER
> + Dataflows can be created
>

Reply via email to