Github user trkurc commented on the pull request:
https://github.com/apache/nifi/pull/104#issuecomment-148874072
Aside from the property validation, it works as expected. I confirmed POSTs
and DELETEs on HOLDs work (using Poster)
Just a quick style question, did you give any thought to not removing the
annotation below and maybe instead changing it to 'Path("*")'?
'''
-@Path(ListenHTTP.URI)
'''
The reason I ask, I was trying to reason through the loop below, and
thought your change may be an opportunity to remove the 'path == null' condition
'''
for (final Class<? extends Servlet> cls : getServerClasses()) {
final Path path = cls.getAnnotation(Path.class);
if (path == null) {
contextHandler.addServlet(cls, uri + "/*");
} else {
contextHandler.addServlet(cls, uri + "/" + path.value());
}
}
...
'''
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
