GitHub user technmsg opened a pull request:

    https://github.com/apache/nifi/pull/106

    NIFI-1046 clean up shell scripts

    Didn't squash specifically to ease review what was changed in each pass.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/technmsg/nifi patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/106.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #106
    
----
commit 5dcebf3aae64e6d564b3e76372b942045b1da9f7
Author: Alex Moundalexis <[email protected]>
Date:   2015-10-19T17:42:28Z

    shell clean up: remove backticks from nifi.sh

commit 909faa59d2002b16a734a8dcad32e04a99cd9b11
Author: Alex Moundalexis <[email protected]>
Date:   2015-10-19T18:02:39Z

    shell clean up: quoting prevents globbing & word splitting
    
    Ignoring the unquoted array expansions on L188/190; suspect they ought to 
be quoted per [SC2068](https://github.com/koalaman/shellcheck/wiki/SC2068), but 
need to confirm desired arguments.

commit 7f3b38324398336f47e2179796014f7e6c7c52dd
Author: Alex Moundalexis <[email protected]>
Date:   2015-10-19T18:14:32Z

    shell clean up: +variable braces for consistency

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to