thanks mike/adam. Doing now. Hold onto your source codes.
On Thu, Nov 12, 2015 at 5:54 PM, Adam Taft <[email protected]> wrote: > git revert is your friend. > > https://git-scm.com/docs/git-revert > > It's not "rollback" -- it's another new commit with the changes reinstated. > > On Thu, Nov 12, 2015 at 5:45 PM, Joe Witt <[email protected]> wrote: > >> ok - will undo the commit. I get to learn a new git trick? Or just >> add them back? I must admit I'm not sure how best to do that. >> >> On Thu, Nov 12, 2015 at 5:39 PM, Brandon DeVries <[email protected]> wrote: >> > I would undo the removal for now, and make a point of doing the test >> > properly. I don't like the idea of removing the test and saying we'll add >> > new ones eventually (those sorts of things tend to not happen...). >> > >> > Brandon >> > On Thu, Nov 12, 2015 at 5:36 PM Tony Kurc <[email protected]> wrote: >> > >> >> Shipping built jars that tests depend on is icky. Not shipping the >> source >> >> to those tests is ickier. >> >> On Nov 12, 2015 5:34 PM, "Joe Witt" <[email protected]> wrote: >> >> >> >> > i think we should kill those tests which depend on the build of those >> >> > jars personally. But if the view is to undo the removal of those >> >> > three classes i can do that. >> >> > >> >> > Thanks >> >> > Joe >> >> > >> >> > On Thu, Nov 12, 2015 at 5:32 PM, Tony Kurc <[email protected]> wrote: >> >> > > Do you plan to undo the removal? >> >> > > On Nov 12, 2015 4:46 PM, "Joe Witt" <[email protected]> wrote: >> >> > > >> >> > >> well that explains these goofball classes I deleted the other day >> >> > >> >> >> > >> https://issues.apache.org/jira/browse/NIFI-1134 >> >> > >> >> >> > >> These classes were used to make those Jars. Those jars are used to >> >> > >> test execute command. We've now removed the source that was >> floating >> >> > >> randomly. We need the built to automatically create whatever we >> >> > >> execute against if we're going to do this. Those tests should be >> >> > >> replaced by something else. >> >> > >> >> >> > >> >> >> > >> On Thu, Nov 12, 2015 at 3:02 PM, Joe Percivall >> >> > >> <[email protected]> wrote: >> >> > >> > Tony, >> >> > >> > >> >> > >> > I did a bit of digging through the history and the jars were a >> part >> >> of >> >> > >> the initial code import so unless if Joe or someone else knows >> where >> >> > they >> >> > >> came from then we may be out of luck. >> >> > >> > >> >> > >> > Joe >> >> > >> > >> >> > >> > - - - - - - >> >> > >> > Joseph Percivall >> >> > >> > linkedin.com/in/Percivall >> >> > >> > e: [email protected] >> >> > >> > >> >> > >> > >> >> > >> > >> >> > >> > >> >> > >> > On Wednesday, November 11, 2015 6:23 PM, Tony Kurc < >> >> [email protected]> >> >> > >> wrote: >> >> > >> > >> >> > >> > >> >> > >> > >> >> > >> > All, I was code reviewing and something occurred to me. This >> raised >> >> my >> >> > >> > eyebrow: >> >> > >> > >> >> > >> >> >> > >> >> >> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestExecuteStreamCommand.java#L63 >> >> > >> > >> >> > >> > If I'm reading it right, the test "runs" a jar that we've got in >> our >> >> > >> source >> >> > >> > tree >> >> > >> > >> >> > >> > What code made those jars in src/test/resources? >> >> > >> >> >> > >> >> >>
