Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/125#issuecomment-156770044
Naveen, thanks for contributing this back! Certainly a nice addition to the
GetKafka processor. The patch looks good, but I did have just a couple of small
points of feedback.
For the PropertyDescriptor added, it may helpful to explain in a little
more detail in the "description" what exactly the property controls & when it
takes effect, for those who may be less familiar with Kafka.
I was also a bit confused by the addition of the @WritesAttribute
annotation - it indicates that the outgoing FlowFile will have an attribute
named "auto.offset.reset" but that attribute is not added to the FlowFile. This
may be a misunderstanding of what the @WritesAttribute annotation is used for
perhaps?
Otherwise, the patch looks great. Thanks again for taking the time to
submit the pull request!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
