Hey Tony, Regarding BAOS vs ByteArrayOutputStream, I made it ByteArrayOutputStream because it a utility class within the standard processors package and not an inner private class. I figured we don't know for sure if everyone knows what BAOS is off the top of their head (I didn't at first) so better to be on the safe side for when people are looking for utility.
For the Notice, I talked with a couple people and it is my understanding that all we needed to do was include the source that we are using (BoundedByteArrayOutputStream.java) and any notices in the Hadoop project Notice file [1], which there isn't. Whether or not their Notice file is wrong is another story though. [1] https://github.com/apache/hadoop/blob/trunk/NOTICE.txt Joe - - - - - - Joseph Percivall linkedin.com/in/Percivall e: [email protected] On Wednesday, November 18, 2015 6:26 PM, Tony Kurc <[email protected]> wrote: I've reviewing Joseph Percivall's NIFI-1081. It added org.apache.nifi.processors.standard.util.SoftLimitBoundedBAOS How do we feel about BAOS vs ByteArrayOutputStream? Also, it was heavily based on Hadoop's implementation of I believe org.apache.hadoop.io.BoundedByteArrayOutputStream [1] The below snippet was added to the NOTICE, I'm not sure if it is right. How do we credit another apache project, hadoop, with providing the basis? I didn't see an obvious example of this already in the source tree ============= BEGIN SNIPPET ============ This product includes the following work from the Apache Hadoop project: BoundedByteArrayOutputStream.java ============= END SNIPPET ============== [1] https://github.com/apache/hadoop/blob/3b85bd7c3391719624a261f061a67cc4356be477/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/BoundedByteArrayOutputStream.java
