Github user joewitt commented on the pull request:
https://github.com/apache/nifi/pull/128#issuecomment-158074311
Ryan,
Definitely appreciate you trying to make it less size prohibitive. I think
we'll want to avoid having shaded jars and such being utilized for this. It
complicates the licensing and related concerns and we have done an extremely
good job getting those clean even to the point of every binary artifact we
produce (nars) having embedded license/notice data correct to all
sub-dependencies.
This is an area which really highlights our need to tackle the extension
registry. We need to, on the other side of this release, figure out how we as
a community can get more agility for releasing extensions like this versus the
core framework.
OlegZ: We do need to tackle any copyright assertions on contributed source
and ensure all proper license and notice adherence occurs. I'm overly
generalizing here but there are like maybe five people on earth (I'm looking at
you Sean Busbey) that care about following the strict guidance of licensing and
notices at the level we do. In basically every contrib that brings in
dependencies we'll have to help others most likely. Feels like a fine trade in
exchange for contributions of helpful things the community will benefit from.
We also need to ensure that there is appropriate testing. However, above
all else we need to keep in mind this community is powered by contributions.
So in every exchange let's make sure our discussions stay focused on helping
folks bring contribs along. As specific example consider the lack of unit
tests. We could as part of the review build them. Or as part of the feedback
ask if there are ideas on how to include some. Some extensions and
contributions are inherently really hard to unit test. I don't know if this
one is or isn't. Adding unit tests or asking if unit tests can be included is
more powerful than saying we can't accept the contrib without them. The
difference can at times be subtle but the effect on the community and tenor of
discussion can be dramatic.
So far everyone in the community has done an awesome job of helping each
other find the middle ground on contributions so that we can be inclusive and
encouraging while increasing quality as well.
Thanks
Joe
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
