Github user trkurc commented on a diff in the pull request:
https://github.com/apache/nifi/pull/132#discussion_r45942561
--- Diff:
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/s3/PutS3Object.java
---
@@ -102,6 +177,94 @@ protected PropertyDescriptor
getSupportedDynamicPropertyDescriptor(final String
.build();
}
+ protected File getPersistenceFile() {
+ return new File(PERSISTENCE_ROOT + getIdentifier());
+ }
+
+ @Override
+ public void onPropertyModified(final PropertyDescriptor descriptor,
final String oldValue, final String newValue) {
+ if (descriptor.equals(KEY)
+ || descriptor.equals(BUCKET)
+ || descriptor.equals(ENDPOINT_OVERRIDE)
+ || descriptor.equals(STORAGE_CLASS)
+ || descriptor.equals(REGION)) {
+ destroyState();
+ }
+ }
+
+ protected MultipartState getState(final String s3ObjectKey) throws
IOException {
--- End diff --
I believe these methods could be problematic if multiple threads are
monkeying with the persistence file at the same time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
