Github user apiri commented on the pull request:
https://github.com/apache/nifi/pull/138#issuecomment-161473916
Good catch and certainly makes a lot of sense.
Code change looks good and certainly in line with the Javadoc for
SecureRandom and makes a lot of sense to that end. All tests pass and this
should not affect any backwards compatibility.
Only area is that of the starred imports that were likely done by your IDE.
These violate the checkstyle setup for the project (you can run this via mvn
<goals> -Pcontrib-check).
If adjusting these to be single imports is okay with you, I can make the
adjustment and close out. Otherwise if you would like to do so, feel free to
push up another commit to the branch you made the PR from.
Thanks for the contribution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
