Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/141#issuecomment-167591336
@olegz - I'm very happy that you are digging in here. This bit of code
certainly could use some TLC and refactoring. I very much like the approach of
moving this logic into the StandardControllerServiceNode object instead of the
scheduler. I did notice one issue that appears to be a race condition if
enable() and disable() are running in parallel (commented inline). Otherwise,
I've not seen any other issues but will continue to review this. Thanks again
for tackling this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
