Github user rpmiskin commented on the pull request:
https://github.com/apache/nifi/pull/165#issuecomment-171761193
@markap14 I chose to provide a Logger implementation to avoid having to
make many changes to MockProcessorLog, especially as there are a number of
methods that make two logger calls (e.g. line 162 and line 213).
Additionally it ensure that all messages would be made available to via
TestRunner even if someone comes along and updates MockProcessorLog with
additional methods.
@olegz Using the underlying output stream would work, but being able to
assert on the objects being passed to the logger may be more helpful for the
tests. There was also a post on the dev list this week about
testShouldValidatePGPPublicKeyringExists failing due to a platform dependent
toString(), that suggests that avoiding asserts based on toString() would be
good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
