Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/185#issuecomment-175089667
@mattyb149 wow this set of Processors is quite a feat! :) I provided
feedback in the way of several inline comments. The only other thing that I
would recommend is to consider factoring out a parent Abstract class or a util
class. It seems like both Processors have quite a lot of overlap that could be
simplified with either one of those approaches. Very cool to get these
Processors in though! THanks for all of the work that you've put into getting
this done!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
