Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/180#discussion_r51490929
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/AbstractElasticsearchProcessor.java
---
@@ -0,0 +1,227 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.processors.elasticsearch;
+
+import org.apache.nifi.annotation.lifecycle.OnStopped;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.Validator;
+import org.apache.nifi.logging.ProcessorLog;
+import org.apache.nifi.processor.AbstractProcessor;
+import org.apache.nifi.processor.ProcessContext;
+import org.apache.nifi.processor.exception.ProcessException;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.ssl.SSLContextService;
+import org.apache.nifi.util.StringUtils;
+import org.elasticsearch.client.Client;
+import org.elasticsearch.client.transport.TransportClient;
+import org.elasticsearch.common.settings.Settings;
+import org.elasticsearch.common.transport.InetSocketTransportAddress;
+
+import java.net.InetSocketAddress;
+import java.net.MalformedURLException;
+import java.net.URL;
+import java.net.URLClassLoader;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import java.util.concurrent.atomic.AtomicReference;
+
+
+public abstract class AbstractElasticsearchProcessor extends
AbstractProcessor {
+
+ protected static final PropertyDescriptor CLUSTER_NAME = new
PropertyDescriptor.Builder()
+ .name("Cluster Name")
+ .description("Name of the ES cluster (for example,
elasticsearch_brew). Defaults to 'elasticsearch'")
+ .required(false)
+ .addValidator(Validator.VALID)
+ .defaultValue("elasticsearch")
+ .build();
+ protected static final PropertyDescriptor HOSTS = new
PropertyDescriptor.Builder()
+ .name("ElasticSearch Hosts")
+ .description("ElasticSearch Hosts, which should be comma
separated and colon for hostname/port "
+ + "host1:port,host2:port,.... For example
testcluster:9200.")
+ .required(true)
+ .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+ .build();
+
+ public static final PropertyDescriptor PROP_SSL_CONTEXT_SERVICE = new
PropertyDescriptor.Builder()
+ .name("SSL Context Service")
+ .description("The SSL Context Service used to provide client
certificate information for TLS/SSL "
+ + "connections. This service only applies if the
Shield plugin is available.")
+ .required(false)
+ .identifiesControllerService(SSLContextService.class)
+ .build();
+
+ public static final PropertyDescriptor PROP_SHIELD_LOCATION = new
PropertyDescriptor.Builder()
+ .name("Shield plugin URL")
+ .description("Specifies the location of the JAR for the
Elasticsearch Shield plugin."
+ + " If the Elasticsearch cluster has been secured with
the Shield plugin, then "
+ + "an SSL Context Service must be defined, and the
Shield plugin JAR must also "
+ + "be available to this processor.")
+ .required(false)
+ .addValidator(StandardValidators.URL_VALIDATOR)
+ .build();
+
+ protected static final PropertyDescriptor PING_TIMEOUT = new
PropertyDescriptor.Builder()
+ .name("ElasticSearch Ping Timeout")
+ .description("The ping timeout used to determine when a node
is unreachable. " +
+ "For example, 5s (5 seconds). If non-local recommended
is 30s")
+ .required(true)
+ .defaultValue("5s")
+ .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+ .build();
+
+ protected static final PropertyDescriptor SAMPLER_INTERVAL = new
PropertyDescriptor.Builder()
+ .name("Sampler Interval")
+ .description("Node sampler interval. For example, 5s (5
seconds) If non-local recommended is 30s")
+ .required(true)
+ .defaultValue("5s")
+ .addValidator(StandardValidators.NON_EMPTY_VALIDATOR)
+ .build();
+
+ protected static final PropertyDescriptor CHARSET = new
PropertyDescriptor.Builder()
+ .name("Character Set")
+ .description("Specifies the character set of the document
data.")
+ .required(true)
+ .defaultValue("UTF-8")
+ .addValidator(StandardValidators.CHARACTER_SET_VALIDATOR)
+ .build();
+
+ protected AtomicReference<Client> esClient = new AtomicReference<>();
+ protected List<InetSocketAddress> esHosts;
+
+ /**
+ * Instantiate ElasticSearch Client. This should be called by
subclasses' onTrigger() method to create a client
+ * if one does not yet exist. The client will be destroyed when the
processor is stopped.
+ *
+ * @param context The context for this processor
+ * @throws ProcessException if an error occurs while creating an
Elasticsearch client
+ */
+ protected void createElasticsearchClient(ProcessContext context)
throws ProcessException {
+
+ ProcessorLog log = getLogger();
+ if (esClient.get() != null) {
+ return;
+ }
+
+ log.info("Creating ElasticSearch Client");
+
+ try {
+ final String clusterName =
context.getProperty(CLUSTER_NAME).toString();
+ final String pingTimeout =
context.getProperty(PING_TIMEOUT).toString();
+ final String samplerInterval =
context.getProperty(SAMPLER_INTERVAL).toString();
+
+ final SSLContextService sslService =
+
context.getProperty(PROP_SSL_CONTEXT_SERVICE).asControllerService(SSLContextService.class);
+
+ Settings.Builder settingsBuilder = Settings.settingsBuilder()
+ .put("cluster.name", clusterName)
+ .put("client.transport.ping_timeout", pingTimeout)
+ .put("client.transport.nodes_sampler_interval",
samplerInterval);
+
+ String shieldUrl = null;
+ if (sslService != null) {
+ shieldUrl =
context.getProperty(PROP_SHIELD_LOCATION).getValue();
+ settingsBuilder.put("shield.transport.ssl", "true")
+ .put("shield.ssl.keystore.path",
sslService.getKeyStoreFile())
+ .put("shield.ssl.keystore.password",
sslService.getKeyStorePassword())
+ .put("shield.ssl.truststore.path",
sslService.getTrustStoreFile())
+ .put("shield.ssl.truststore.password",
sslService.getTrustStorePassword());
+ }
+
+ TransportClient transportClient =
getTransportClient(settingsBuilder, shieldUrl);
+
+ final String hosts = context.getProperty(HOSTS).getValue();
+ esHosts = getEsHosts(hosts);
+
+ if (esHosts != null) {
+ for (final InetSocketAddress host : esHosts) {
+ transportClient.addTransportAddress(new
InetSocketTransportAddress(host));
+ }
+ }
+ esClient.set(transportClient);
+
+ } catch (Exception e) {
+ log.error("Failed to create Elasticsearch client due to {}",
new Object[]{e}, e);
+ throw new ProcessException(e);
+ }
+ }
+
+ protected TransportClient getTransportClient(Settings.Builder
settingsBuilder, String shieldUrl)
+ throws MalformedURLException {
+
+ // Create new transport client using the Builder pattern
+ TransportClient.Builder builder = TransportClient.builder();
+
+ // See if the Elasticsearch Shield JAR location was specified, and
add the plugin if so
+
+ final ClassLoader originalClassLoader =
Thread.currentThread().getContextClassLoader();
+ if (!StringUtils.isBlank(shieldUrl)) {
+ Thread.currentThread().setContextClassLoader(
+ new URLClassLoader(new URL[]{new URL(shieldUrl)},
this.getClass().getClassLoader()));
+ }
+ try {
+ Class shieldPluginClass =
Class.forName("org.elasticsearch.shield.ShieldPlugin", true,
+ Thread.currentThread().getContextClassLoader());
+ builder = builder.addPlugin(shieldPluginClass);
+ } catch (ClassNotFoundException cnfe) {
+ getLogger().debug("Did not detect Elasticsearch Shield plugin,
secure connections will not be available");
+ }
+
+ TransportClient transportClient =
builder.settings(settingsBuilder.build()).build();
+ Thread.currentThread().setContextClassLoader(originalClassLoader);
+ return transportClient;
+ }
+
+ /**
+ * Dispose of ElasticSearch client
+ */
+ @OnStopped
+ public final void closeClient() {
+ if (esClient.get() != null) {
+ getLogger().info("Closing ElasticSearch Client");
+ esClient.get().close();
+ esClient.set(null);
+ }
+ }
+
+ /**
+ * Get the ElasticSearch hosts from a Nifi attribute, e.g.
+ *
+ * @param hosts A comma-separated list of ElasticSearch hosts
(host:port,host2:port2, etc.)
+ * @return List of InetSocketAddresses for the ES hosts
+ */
+ private List<InetSocketAddress> getEsHosts(String hosts) {
+
+ if (hosts == null) {
+ return null;
+ }
+ final List<String> esList = Arrays.asList(hosts.split(","));
+ List<InetSocketAddress> esHosts = new ArrayList<>();
+
+ for (String item : esList) {
+
+ String[] addresses = item.split(":");
+ // Protect against invalid input like http://127.0.0.1:9300
(URL scheme should not be there)
--- End diff --
This should be included (implemented instead of just a todo comment). I
tried PutElasticSearch with http://localhost:9300 and it blew up causing an out
of memory error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
