Github user markap14 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/200#discussion_r51600893
  
    --- Diff: 
nifi-nar-bundles/nifi-amqp-bundle/nifi-amqp-processors/src/main/java/org/apache/nifi/amqp/processors/PublishAMQP.java
 ---
    @@ -0,0 +1,219 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.amqp.processors;
    +
    +import java.io.IOException;
    +import java.io.InputStream;
    +import java.lang.reflect.Method;
    +import java.util.ArrayList;
    +import java.util.Collections;
    +import java.util.HashSet;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.Map.Entry;
    +import java.util.Properties;
    +import java.util.Set;
    +
    +import org.apache.nifi.annotation.behavior.InputRequirement;
    +import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
    +import org.apache.nifi.annotation.documentation.CapabilityDescription;
    +import org.apache.nifi.annotation.documentation.Tags;
    +import org.apache.nifi.components.PropertyDescriptor;
    +import org.apache.nifi.components.Validator;
    +import org.apache.nifi.flowfile.FlowFile;
    +import org.apache.nifi.processor.ProcessContext;
    +import org.apache.nifi.processor.ProcessSession;
    +import org.apache.nifi.processor.Relationship;
    +import org.apache.nifi.processor.exception.ProcessException;
    +import org.apache.nifi.processor.io.InputStreamCallback;
    +import org.apache.nifi.processor.util.StandardValidators;
    +import org.apache.nifi.stream.io.StreamUtils;
    +
    +import com.rabbitmq.client.AMQP;
    +import com.rabbitmq.client.AMQP.BasicProperties;
    +
    +/**
    + * Publishing AMQP processor which upon each invocation of
    + * {@link #onTrigger(ProcessContext, ProcessSession)} method will 
construct an
    + * AMQP message sending it to an exchange identified during construction 
of this
    + * class while transferring the incoming {@link FlowFile} to 'success'
    + * {@link Relationship}.
    + *
    + * Expects that queues, exchanges and bindings are pre-defined by an AMQP
    + * administrator
    + */
    +@Tags({ "amqp", "rabbit", "put", "message", "send", "publish" })
    +@InputRequirement(Requirement.INPUT_REQUIRED)
    +@CapabilityDescription("Creates a AMQP Message from the contents of a 
FlowFile and sends the message to an AMQP Server")
    +public class PublishAMQP extends AbstractAMQPProcessor<AMQPPublisher> {
    +
    +    public static final PropertyDescriptor EXCHANGE = new 
PropertyDescriptor.Builder()
    --- End diff --
    
    Either is ok with me as long as the description lines up with how the 
PropertyDescriptor is configured. Just a little odd to claim that it's optional 
and then make it required :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to