Github user apiri commented on the pull request:

    https://github.com/apache/nifi/pull/223#issuecomment-185443013
  
    @michalklempa looks good.  one minor point that I am adjusting is the usage 
of newProperty at  
https://github.com/apache/nifi/pull/223/files#diff-fe8e954d730443b47cb0a94d340ac271R306
 This is typically for dynamic properties where new values must be created 
because there is no a priori knowledge of them.
    
    Regardless, thanks for detecting and fixing this up and it will be merged 
shortly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to