Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/210#issuecomment-189328683
Otherwise, I think all looks good. I definitely like the simplification of
the code. I agree that the locking is no longer necessary. It was there because
we wanted to atomically evaluate isRunning() and then update the processor, all
as a single unit, without the processor being started in the meantime. However,
this is not really a concern, since starting the processor with a separate
thread would have to be done via the web tier, which will hold a lock anyway.
Great addition! Once the DTO & FlowSerializer are addressed, and the
DISABLED state is added back in, I'll be a +1!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
