Github user bbende commented on the pull request:
https://github.com/apache/nifi/pull/253#issuecomment-193920825
@rickysaltzer if you rebase to master I think the RELP failures should go
away.
Regarding testing, a couple of thoughts...
1) Could we update the validation test to include the new logic for
Kerberos?
https://github.com/apache/nifi/blob/40dd8a0a845ef5f4d4fde451f02376ab2fab9758/nifi-nar-bundles/nifi-standard-services/nifi-hbase_1_1_2-client-service-bundle/nifi-hbase_1_1_2-client-service/src/test/java/org/apache/nifi/hbase/TestHBase_1_1_2_ClientService.java#L61
2) There are also a bunch of tests in there that mock everything, not sure
how feasible this is, but is it possible to add a test where we somehow mocked
the static calls to UserGroupInformation to at least prove that the correct
values are getting passed when security is enabled?
I'm not that familiar with mocking static methods so not sure what this
entails.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
