As I was reviewing a pull request, i realized that it actually was a bit
more mental effort in this instance to review a squashed and rebased set of
commits than if it was if I could just review the changes in a commit. Does
anyone object to me adding in the contributors guide something to the
extent of "Although you may be asked to rebase or squash your contribution
as part of the review process, don't feel the need to do so speculatively.
The committer working on merging the contribution may prefer to do these
types of operations as part of the merge process, and the history of your
patch or pull request may aid in the review process"

Tony

Reply via email to