Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/281#discussion_r56410644
--- Diff:
nifi-commons/nifi-hadoop-utils/src/main/java/org/apache/nifi/hadoop/KerberosProperties.java
---
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.hadoop;
+
+import org.apache.hadoop.conf.Configuration;
+import org.apache.nifi.components.PropertyDescriptor;
+import org.apache.nifi.components.ValidationContext;
+import org.apache.nifi.components.ValidationResult;
+import org.apache.nifi.components.Validator;
+import org.apache.nifi.logging.ComponentLog;
+import org.apache.nifi.processor.util.StandardValidators;
+import org.apache.nifi.util.NiFiProperties;
+import org.apache.nifi.util.StringUtils;
+
+import java.io.File;
+import java.util.ArrayList;
+import java.util.List;
+
+/**
+ * All processors and controller services that need properties for
Kerberos Principal and Keytab
+ * should obtain them through this class by calling:
+ *
+ * KerberosProperties props =
KerberosProperties.create(NiFiProperties.getInstance())
+ *
+ * The properties can be accessed from the resulting KerberosProperties
instance.
+ */
+public class KerberosProperties {
+
+ private final File kerberosConfigFile;
+ private final Validator kerberosConfigValidator;
+ private final PropertyDescriptor kerberosPrincipal;
+ private final PropertyDescriptor kerberosKeytab;
+
+ private KerberosProperties(final File kerberosConfigFile) {
+ this.kerberosConfigFile = kerberosConfigFile;
+
+ if (this.kerberosConfigFile != null) {
+ System.setProperty("java.security.krb5.conf",
kerberosConfigFile.getAbsolutePath());
+ }
+
+ this.kerberosConfigValidator = new Validator() {
+ @Override
+ public ValidationResult validate(String subject, String input,
ValidationContext context) {
+ // Check that the Kerberos configuration is set
+ if (kerberosConfigFile == null) {
+ return new ValidationResult.Builder()
+ .subject(subject).input(input).valid(false)
+ .explanation("you are missing the
nifi.kerberos.krb5.file property which "
+ + "must be set in order to use
Kerberos")
+ .build();
+ }
+
+ // Check that the Kerberos configuration is readable
+ if (!kerberosConfigFile.canRead()) {
+ return new
ValidationResult.Builder().subject(subject).input(input).valid(false)
+ .explanation(String.format("unable to read
Kerberos config [%s], please make sure the path is valid "
+ + "and nifi has adequate permissions",
kerberosConfigFile.getAbsoluteFile()))
+ .build();
+ }
+
+ return new
ValidationResult.Builder().subject(subject).input(input).valid(true).build();
+ }
+ };
+
+ this.kerberosPrincipal = new PropertyDescriptor.Builder()
+ .name("Kerberos Principal")
+ .required(false)
+ .description("Kerberos principal to authenticate as.
Requires nifi.kerberos.krb5.file to be set in your nifi.properties")
+ .addValidator(kerberosConfigValidator)
+ .build();
+
+ this.kerberosKeytab = new PropertyDescriptor.Builder()
+ .name("Kerberos Keytab").required(false)
+ .description("Kerberos keytab associated with the
principal. Requires nifi.kerberos.krb5.file to be set in your nifi.properties")
+ .addValidator(StandardValidators.FILE_EXISTS_VALIDATOR)
+ .addValidator(kerberosConfigValidator)
+ .build();
+ }
+
+ public static KerberosProperties create(final NiFiProperties
niFiProperties) {
+ if (niFiProperties == null) {
+ throw new IllegalArgumentException("NiFiProperties can not be
null");
+ }
+ return new
KerberosProperties(niFiProperties.getKerberosConfigurationFile());
+ }
+
+ public File getKerberosConfigFile() {
+ return kerberosConfigFile;
+ }
+
+ public Validator getKerberosConfigValidator() {
+ return kerberosConfigValidator;
+ }
+
+ public PropertyDescriptor getKerberosPrincipal() {
+ return kerberosPrincipal;
+ }
+
+ public PropertyDescriptor getKerberosKeytab() {
+ return kerberosKeytab;
+ }
+
+ public static List<ValidationResult> validatePrincipalAndKeytab(final
String subject, final Configuration config, final String principal, final
String keytab, final ComponentLog logger) {
+ final List<ValidationResult> results = new ArrayList<>();
+
+ // if security is enabled then the keytab and principal are
required
+ final boolean isSecurityEnabled =
SecurityUtil.isSecurityEnabled(config);
+
+ if (isSecurityEnabled && StringUtils.isBlank(principal)) {
+ results.add(new ValidationResult.Builder()
+ .valid(false)
+ .subject(subject)
+ .explanation("Kerberos Principal must be provided when
using a secure HBase")
--- End diff --
I'm guessing this is due to some refactoring, but we should probably not
mention using a secure HBase in a general KerberosProperties class
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
