Chris, My IDE does the same. It is preferable to undo those changes to minimize the impact of the PR and help reviewers focus on actual code changes. You can use the git rebase command to remove individual changes or you can copy/paste the original ordering of the imports and commit again, and the end result will be the same. Thanks.
Andy LoPresto [email protected] PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69 > On Mar 24, 2016, at 9:17 AM, McDermott, Chris Kevin (MSDU - > STaTS/StorefrontRemote) <[email protected]> wrote: > > I’m getting a pull request ready and discovered that my IDE did a bunch of > code “cleanup” on the files I modified. The cleanup is mostly reordering > imports and removing leading and trailing whitespace. Are these changes > desirable/acceptable or do I need to go back and undo them? > > The commit can be found here > https://github.com/ckmcd/nifi/commit/485f8ce39b3e621f0659b2d91fe3945b29c39805 > > Thanks, > Chris >
signature.asc
Description: Message signed with OpenPGP using GPGMail
