Github user markap14 commented on the pull request:
https://github.com/apache/nifi/pull/306#issuecomment-202419168
@ToivoAdams very cool that you're tackling this! Thanks for jumping in! The
only concern that I have with this patch is that if we end up with a buggy
processor that starts generating TONS of bulletins, or if we have something
like LogAttribute running and continually generating bulletins, creating the
LinkedHashMap continually is fairly expensive. What do you think about using a
CircularLifoQueue, which is in the Commons Collections package? I'll attach a
patch to the JIRA so you can see exactly what i'm thinking. I think it'll
simplify the logic a good bit, and the unit tests that you put together will be
perfect to test it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
