Github user mcgilman commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/312#discussion_r57917189
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java
 ---
    @@ -2539,6 +2539,12 @@ private ProcessorStatus getProcessorStatus(final 
RepositoryStatusReport report,
             return status;
         }
     
    +    private boolean isValid(ProcessorNode procNode) {
    +        try (final NarCloseable narCloseable = 
NarCloseable.withNarLoader()) {
    +            return procNode.isValid();
    --- End diff --
    
    I believe we want to wrap the call into validate() on the Processor in 
procNode.isValid() rather than the entire isValid() method [1].
    
    [1] 
https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/StandardProcessorNode.java#L911


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to