I wrote up a quick guide for reviewers to apply the patches to multiple support branches on the wiki [1].
[1] https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide#ContributorGuide-Stepstomerge/closepullrequestswithtwomainbranches <https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide#ContributorGuide-Stepstomerge/closepullrequestswithtwomainbranches> Andy LoPresto [email protected] [email protected] PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69 > On Apr 4, 2016, at 4:01 PM, Sean Busbey <[email protected]> wrote: > > On Mon, Apr 4, 2016 at 4:40 PM, Adam Lamar <[email protected]> wrote: >> On Mon, Apr 4, 2016 at 11:14 AM, Sean Busbey <[email protected]> wrote: >>> You're correct, a github PR only targets a single branch and Travis-CI >>> only checks how the PR does at its own commit hash (that is, it >>> doesn't even check what the target branch would look like post-merge). >>> >> >> Hey Sean, it looks like Travis-CI does merge into the specified merge >> branch before running. For example, my ListS3 PR [1] has commit >> 2f7e89e, but the Travis-CI status page [1] shows commit e0868c2. If >> you find that in github [2] you'll see it is the merge of 2f7e89e and >> 6f5fb59, where 6f5fb59 is the location of master when I submitted the >> PR. >> > > Excellent. I am very happy to find that I'm incorrect. I must just be > used to using Travis-CI with very old PRs. :)
signature.asc
Description: Message signed with OpenPGP using GPGMail
