Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/15#discussion_r60849783
--- Diff:
minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/configuration/notifiers/RestChangeNotifier.java
---
@@ -227,15 +235,27 @@ public void handle(String target, Request
baseRequest, HttpServletRequest reques
}
}
setConfigFile(configBuilder.substring(0,configBuilder.length()-1));
- notifyListeners();
- writeOutput(response, POST_TEXT, 200);
+ ListenerHandleResult[] listenerHandleResults =
notifyListeners();
+
+ writeOutput(response, getPostText(listenerHandleResults),
200);
--- End diff --
Good call, I changed it to return the text status of the listeners but
didn't change the status code. I can't tell whether the listener failed due to
client or server error so I will just return 200 if all succeeded but 500 if
any failed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
