Github user YolandaMDavis commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/386#discussion_r62165580
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/bin/nifi-env.bat
 ---
    @@ -0,0 +1,29 @@
    +@echo off
    +rem
    +rem    Licensed to the Apache Software Foundation (ASF) under one or more
    +rem    contributor license agreements.  See the NOTICE file distributed 
with
    +rem    this work for additional information regarding copyright ownership.
    +rem    The ASF licenses this file to You under the Apache License, Version 
2.0
    +rem    (the "License"); you may not use this file except in compliance with
    +rem    the License.  You may obtain a copy of the License at
    +rem
    +rem       http://www.apache.org/licenses/LICENSE-2.0
    +rem
    +rem    Unless required by applicable law or agreed to in writing, software
    +rem    distributed under the License is distributed on an "AS IS" BASIS,
    +rem    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.
    +rem    See the License for the specific language governing permissions and
    +rem    limitations under the License.
    +rem
    +
    +
    +rem The java implementation to use.
    +rem set JAVA_HOME="C:java\"
    --- End diff --
    
    Not at all valid, that's a typo :) . I think what I'll do is leave it blank 
but have an example directory location in the above comment, since it can vary 
by windows/java version. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to