Github user joewitt commented on a diff in the pull request:
https://github.com/apache/nifi/pull/430#discussion_r63239852
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/repository/StandardProcessSession.java
---
@@ -175,6 +184,10 @@ public StandardProcessSession(final ProcessContext
context) {
this.sessionId = idGenerator.getAndIncrement();
this.connectableDescription = description;
+ this.isRollbackCountEnabled =
NiFiProperties.getInstance().isRollbackCountEnabled();
+ this.isRollbackLogUnackFFEnabled =
NiFiProperties.getInstance().isRollbackLogUnackFFEnabled();
+ this.rollbackLogUnackFFMax =
NiFiProperties.getInstance().getRollbackLogUnackFFMax();
+
--- End diff --
not about this line specifically but it doesn't look like we'd be resetting
the flow file attributes after a given flow file was able to get passed a given
processor's commit call. Thus we could have rollback counts on attributes that
don't make sense any more since it was about a different processor. In either
case, we won't have the attributes retained anyway because unless a commit
happens there are no flow file attribute changes occurring.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
