Github user mcgilman commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/424#discussion_r63452681
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java
 ---
    @@ -1670,6 +1670,49 @@ public ProcessorDTO getConfiguration() {
         }
     
         @Override
    +    public ConfigurationSnapshot<ProcessorDTO> 
setProcessorProperties(final Revision revision, final String processorId, final 
Map<String,String> properties) {
    --- End diff --
    
    I think it may make sense to just use updateProcessor(...) instead 
introducing setProcessorProperties(...). We should probably even get rid of 
setProcessorAnnotationData(...) in favor of updateProcessor(...). In earlier 
version of NiFi, these values were setting differently which is why there was 
two different method. However, now I think we can consolidate these.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to