Github user rstjohn commented on the pull request:
https://github.com/apache/nifi/pull/256#issuecomment-220169135
Our use case would benefit from having all of the attachment fields
available. The implementation I had in mind was to use dynamic
properties. Each dynamic property would represent an item in the the
attachments array. Each dynamic property would support expression language
and would fail gracefully if it is not a properly formed json string. I
can live with the webhook as a sensitive field, but I personally think it
is overkill. Anyone can look in the Dev tools to see the url and if you
are trying to protect someone from themselves, that it a lost cause.
Richard St. John, Ph.D.
On May 18, 2016 2:04 PM, "adamonduty" <[email protected]> wrote:
> @rstjohn <https://github.com/rstjohn> I agree with @alopresto
> <https://github.com/alopresto> - the webhook is sensitive. Especially
> because the links and content posted on slack are generally internal to
> teams and trusted, inadvertently exposing a webhook URL could leave teams
> open to phishing attacks. And possession of a webhook URL allows one to
> post to *any* public channel or direct message any user.
>
> You have a great point about the validator - it should validate *after*
> the expression language has been applied to allow for use cases like you
> describe. I'm a bit on the fence on assuming a name without a # is a
> channel name though.
>
> We could also expose the attachments section. Did you envision a property
> where you could supply a json array as described in Slack's documentation
> <https://api.slack.com/docs/attachments>? Or did you have another
> approach in mind?
>
> â
> You are receiving this because you were mentioned.
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/nifi/pull/256#issuecomment-220109946>
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
