Github user aperepel commented on a diff in the pull request:
https://github.com/apache/nifi/pull/456#discussion_r64040583
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExecuteProcess.java
---
@@ -181,7 +183,14 @@ public Thread newThread(final Runnable r) {
@OnUnscheduled
public void shutdownExecutor() {
- executor.shutdown();
+ try {
+ executor.shutdown();
+ } finally {
+ if (this.externalProcess.isAlive()) {
+ this.getLogger().warn("Interrupting external process since
it did not finished at the time stop Processor was initiated.");
--- End diff --
Check for typos and wording, maybe simplify it? How about 'Process hasn't
terminated on request, forcing the interrupt'?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
