Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/461#discussion_r64248023
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/groups/ProcessGroup.java
---
@@ -46,6 +48,26 @@
public interface ProcessGroup extends Authorizable {
/**
+ * Predicate for filtering schedulable Processors.
+ */
+ Predicate<ProcessorNode> SCHEDULABLE_PROCESSORS = node ->
!node.isRunning() && node.getScheduledState() != ScheduledState.DISABLED;
+
+ /**
+ * Predicate for filtering unschedulable Processors.
+ */
+ Predicate<ProcessorNode> UNSCHEDULABLE_PROCESSORS = node ->
node.isRunning();
+
+ /**
+ * Predicate for filtering schedulable Ports
+ */
+ Predicate<Port> SCHEDULABLE_PORTS = port -> port.getScheduledState()
!= ScheduledState.DISABLED;
+
+ /**
+ * Predicate for filtering schedulable Ports
+ */
+ Predicate<Port> UNSCHEDULABLE_PORTS = port -> port.getScheduledState()
== ScheduledState.RUNNING;
--- End diff --
Shouldn't this be "port.isRunning()" instead, like we do for Processor? It
seems like we could actually just have a SCHEDULABLE_TRIGGERABLE and an
UNSCHEDULABLE_TRIGGERABLE rather than separate ones for ports & processors?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
