Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi/pull/17#discussion_r64732477
--- Diff:
minifi-bootstrap/src/main/java/org/apache/nifi/minifi/bootstrap/util/ConfigTransformer.java
---
@@ -616,15 +630,21 @@ private static void addConnection(final Element
parentElement, Map<String, Objec
addTextElement(element, "labelIndex", "1");
addTextElement(element, "zIndex", "0");
- addTextElement(element, "sourceId", "Processor");
+ addTextElement(element, "sourceId",
getValueString(connectionProperties, SOURCE_NAME_KEY));
--- End diff --
One additional thought I had was to have another class that perhaps does
the value checking and enforces the config YAML and then passes a value object
(a collection of all the backing maps) to the ConfigTransformer. Long term, we
may not have this particular process and could isolate the actual validation
and checking elsewhere. In lieu of the manual checks, we may be able to make
use of something like [Kwalify](http://www.kuwata-lab.com/kwalify/) (no clue as
to its quality) which might help in cutting down on the onerous and manual if
statements for each individual scalar.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
