Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/477
@mattyb149 Looks good for the most part. I left a few inline comments, just
some tweaks that i think can probably help to cleanup the code. Also, I noticed
OrcFlowFileWriter.java is a pretty hefty file. I think this is a slight
modification to one of the writers in the Orc codebase, correct? does it make
sense to instead create a PR for Apache Orc so that they can incorporate the
slight change that is needed, instead of having to maintain that huge file that
could change over time?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
