Github user mcgilman commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/577#discussion_r68448885
  
    --- Diff: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/provenance/nf-provenance.js
 ---
    @@ -223,11 +227,32 @@ nf.Provenance = (function () {
                             });
                         }
     
    -                    // once the table is initialized, finish initializing 
the page
    -                    initializeProvenancePage().done(function () {
    +                    var setBodySize = function () {
    +                        $('body').css({
    +                            'height': $(window).height() + 'px',
    +                            'width': $(window).width() + 'px'
    +                        });
    +
    +                        var provenanceTableHeight = 
$('#provenance').outerHeight() -
    +                            $('#provenance-header-text').outerHeight() -
    +                            
$('#provenance-refresh-container').outerHeight() - 20; //20 for padding at 
bottom of table
    +                        if (top === window) {
    +                            provenanceTableHeight -= 80; //80 for padding
    +                        }
    +                        
$('#provenance-table').height(provenanceTableHeight).show();
    --- End diff --
    
    I think this logic is unnecessary as the provenance table is bound from the 
bottom using position absolute. The height should adjust due to the CSS rules.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to