I submitted PR 955 to address this. Andy LoPresto [email protected] [email protected] PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69
> On Aug 25, 2016, at 8:21 AM, Joe Skora <[email protected]> wrote: > > I'm working on the TestPostHTTPGroovy.testDefaultShouldPreferTLSv1_2 > problem on ticket NIFI-2618 > <https://issues.apache.org/jira/browse/NIFI-2618> that Mike Moser entered > the other day. > > Per the ticket, I'm trying to fix the test for Java 7 or I may just remove > it. > > On Thu, Aug 25, 2016 at 10:42 AM, Andre <[email protected]> wrote: > >> Joe, >> >> No worries. There were some tabs, trailing spaces and long lines. >> >> I submitted a PR earlier today but we missed a few fixes. There's another >> one to be merged into master >> >> https://github.com/apache/nifi/pull/941 >> >> >> >> On Fri, Aug 26, 2016 at 12:33 AM, Joe Percivall < >> [email protected]> wrote: >> >>> Hello Andre, >>> >>> Thank you for bringing this up. For master branch, I merged in PR 933 >> last >>> night and it appears something got messed up with the squashing. I am >>> working with Matt Gilman to figure out what happened and how to fix it. >>> >>> For 0.x, I am not sure. Andy LoPresto would have to chime in when he >> wakes >>> up (he's on the West coast). >>> >>> Joe >>> >>> - - - - - - >>> Joseph Percivall >>> linkedin.com/in/Percivall >>> e: [email protected] >>> >>> >>> >>> On Thursday, August 25, 2016 10:29 AM, Andre <[email protected]> >> wrote: >>> >>> >>> >>> devs, >>> >>> FYI: those who use travis-ci as an indicator of contrib-check is passing, >>> should be aware travis is experiencing some infrastructure issues and >>> builds are being severely delayed. >>> >>> Also, both master and 0.x are failing. >>> >>> master is failing travis due to style violations on contrib check (Matt B >>> is reviewing the PR) >>> >>> While 0.x seems to be failing due (0.x only fails on Java 7) >>> >>> Failed tests: >>> TestPostHTTPGroovy.testDefaultShouldPreferTLSv1_2:296 assert >>> selectedProtocol == TLSv1_2 >>> | | | >>> TLSv1 | TLSv1.2 >>> false >>> >>> introduced by >>> https://github.com/apache/nifi/commit/24c0c111343d40188bf8b2de06ebeb >>> 39d1cccd88 >>> >>> Cheers >>> >>
signature.asc
Description: Message signed with OpenPGP using GPGMail
