+1 (binding) Release this package as nifi-minifi-cpp-0.0.1 - Ran through the helper - Ran a couple simple flows
Everything worked as expected. This is a great step for MiNiFi! Thank you Bin and Aldrin for all your hard work. Joe - - - - - - Joseph Percivall linkedin.com/in/Percivall e: joeperciv...@yahoo.com On Tuesday, August 30, 2016 2:26 PM, Aldrin Piri <aldrinp...@gmail.com> wrote: As an aside and in response to all the great feedback received thus far, I do want to share some additional information on the perspective of the rationale behind the initial release. By no means is this considered feature complete, but provides some functional bits to establish a basis from which to grow. When we look at some of the ideas originally set up in terms of management and integrating with NiFi at large, an initial offering that can talk with NiFi and espouses many of the same constructs is a first step to that end. We can certainly make additional disclaimers about the current state of the C++ implementation known and document them more fully such that users that are aware of what the community is providing. Some of these are present, but we can do a bit better. Ultimately, this provides additional avenues for folks to contribute and get involved especially as we look at protocols, extensions, and establishing of an ecosystem of components between all that NiFi is and the two offerings of MiNiFi. Thanks! On Mon, Aug 29, 2016 at 11:27 PM, Aldrin Piri <aldrinp...@gmail.com> wrote: > Tony, > > In terms of the GMock, this transitive inclusion was detected but based > off versions, as best as I could surmise is now part of Google Test as per > their repo here: https://github.com/google/googlemock. This inclusion is > covered in the LICENSE [1] > > We can certainly can and should clean up warnings and I will create a JIRA > to cut those down. Some are on us, some are on the libraries that are > compiled as part of the build such that they can be statically linked. > > In terms of the missing flow.yml, that was an oversight in documentation. > I think we can get a bit cleaner on the error if something should happen, > but given the design and deploy type approach this brings, the inclusion of > a default one and/or auto generating one seems a bit out of the spirit of > its original intent. > > [1] https://github.com/apache/nifi-minifi-cpp/blob/master/LICENSE#L308 > > Thanks! > --aldrin > > On Mon, Aug 29, 2016 at 10:46 PM, Andrew Psaltis <psaltis.and...@gmail.com > > wrote: > >> +1 (non-binding) Release this package as nifi-minifi-cpp-0.0.1 >> >> >> - Verified signature, hashes, and LICENSE/NOTICE/README >> - Built source and ran a simple flow with GetFile -> RPG -> Standalone >> NiFi >> - Environment -- MiNiFi Ubuntu 16.04.1 LTS and Standalone NiFi OSX >> >> I also noticed all of the warnings and at least raised a thought -- should >> we be making an effort to clean it up now? Are they acceptable? Or as in >> day's gone by the warning really is a the compiler doing you a favor and >> saying -- "hey this is wrong and it may bite you" . No implying this >> should >> hold up the release, but more of a observation of potential tech-debt. >> >> >> Thanks, >> Andrew >> >> >> >> On Mon, Aug 29, 2016 at 10:19 PM, Tony Kurc <trk...@gmail.com> wrote: >> >> > I had a lot of warnings when I built also, lots of unsigned / signed >> > comparisons, for example. >> > >> > I'm building on a fairly vanilla Ubuntu 14.04 x64_64 box. I can paste if >> > people are interested. >> > >> > On Aug 29, 2016 10:06 PM, "Andy LoPresto" <alopre...@apache.org> wrote: >> > >> > > Downloaded, verified the GPG signature and checksums, checked the >> README, >> > > LICENSE, and NOTICE files. Verified the git commit ID. >> > > >> > > Built with make (had to install boost using Homebrew first). I got a >> > > couple warnings & errors during the make process (documented below) — >> not >> > > sure if they are known issues but they did not stop the build from >> > > completing. >> > > >> > > I followed Koji’s lead and used the sample README flow.yml and sent >> > output >> > > to a local NiFi instance using S2S. Everything worked great. >> > > >> > > +1 (binding) >> > > >> > > Noted issues (let me know if you would like me to report these as >> Jiras): >> > > >> > > During `make`: >> > > >> > > gcc -g -Wall -rdynamic -O0 -ggdb -g3 -fexceptions -Wno-write-strings >> > > -fvisibility=hidden -fPIC -I.. -c clear.c -o clear.o >> > > clang: warning: argument unused during compilation: '-rdynamic' >> > > gcc -g -Wall -rdynamic -O0 -ggdb -g3 -fexceptions -Wno-write-strings >> > > -fvisibility=hidden -fPIC -I.. -c compare.c -o compare.o >> > > clang: warning: argument unused during compilation: '-rdynamic' >> > > gcc -g -Wall -rdynamic -O0 -ggdb -g3 -fexceptions -Wno-write-strings >> > > -fvisibility=hidden -fPIC -I.. -c copy.c -o copy.o >> > > clang: warning: argument unused during compilation: '-rdynamic' >> > > gcc -g -Wall -rdynamic -O0 -ggdb -g3 -fexceptions -Wno-write-strings >> > > -fvisibility=hidden -fPIC -I.. -c gen_uuid.c -o gen_uuid.o >> > > clang: warning: argument unused during compilation: '-rdynamic' >> > > gcc -g -Wall -rdynamic -O0 -ggdb -g3 -fexceptions -Wno-write-strings >> > > -fvisibility=hidden -fPIC -I.. -c isnull.c -o isnull.o >> > > clang: warning: argument unused during compilation: '-rdynamic' >> > > gcc -g -Wall -rdynamic -O0 -ggdb -g3 -fexceptions -Wno-write-strings >> > > -fvisibility=hidden -fPIC -I.. -c pack.c -o pack.o >> > > clang: warning: argument unused during compilation: '-rdynamic' >> > > gcc -g -Wall -rdynamic -O0 -ggdb -g3 -fexceptions -Wno-write-strings >> > > -fvisibility=hidden -fPIC -I.. -c parse.c -o parse.o >> > > clang: warning: argument unused during compilation: '-rdynamic' >> > > gcc -g -Wall -rdynamic -O0 -ggdb -g3 -fexceptions -Wno-write-strings >> > > -fvisibility=hidden -fPIC -I.. -c unpack.c -o unpack.o >> > > clang: warning: argument unused during compilation: '-rdynamic' >> > > gcc -g -Wall -rdynamic -O0 -ggdb -g3 -fexceptions -Wno-write-strings >> > > -fvisibility=hidden -fPIC -I.. -c unparse.c -o unparse.o >> > > clang: warning: argument unused during compilation: '-rdynamic' >> > > gcc -g -Wall -rdynamic -O0 -ggdb -g3 -fexceptions -Wno-write-strings >> > > -fvisibility=hidden -fPIC -I.. -c uuid_time.c -o uuid_time.o >> > > clang: warning: argument unused during compilation: '-rdynamic' >> > > >> > > ... >> > > >> > > >> > > src/FlowController.cpp:83:7: warning: unused variable 'flow_full_path' >> > > [-Wunused-variable] >> > > char flow_full_path[PATH_MAX]; >> > > ^ >> > > src/FlowController.cpp:82:8: warning: unused variable 'flowPath' >> > > [-Wunused-variable] >> > > char *flowPath = NULL; >> > > ^ >> > > 2 warnings generated. >> > > >> > > ... >> > > >> > > >> > > g++ -Os -fexceptions -fpermissive -Wno-write-strings -std=c++11 -fPIC >> > > -Wall -g -Wno-unused-private-field -I./inc -I./src -I./test >> > -I./thirdparty >> > > -I/usr/include/libxml2 -I./thirdparty/yaml-cpp-yaml-cpp-0.5.3/include >> -o >> > > ./build/Server test/Server.cpp -L./build -L./thirdparty/uuid >> > > -L./thirdparty/yaml-cpp-yaml-cpp-0.5.3/lib/ -lminifi -lxml2 -pthread >> > > -luuid -lyaml-cpp >> > > clang: error: no such file or directory: 'test/Server.cpp' >> > > make: [tests] Error 1 (ignored) >> > > >> > > In minifi.properties (is there a reason this is nifi.version instead >> of >> > > minifi.version?): >> > > >> > > # Core Properties # >> > > nifi.version=0.0.1 >> > > >> > > Andy LoPresto >> > > alopre...@apache.org >> > > *alopresto.apa...@gmail.com <alopresto.apa...@gmail.com>* >> > > PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69 >> > > >> > > On Aug 29, 2016, at 4:47 PM, Koji Kawamura <ijokaruma...@gmail.com> >> > wrote: >> > > >> > > +1 (non-binding) >> > > >> > > Downloaded the source archive, verified signature, md5, sha1, and >> > > sha256 hashes are all good. >> > > LICENSE file looks good >> > > Built the source successfully with the steps written in README, on Mac >> > > OS X El Captain >> > > Used brew to install boost: $ brew install boost >> > > Created conf/flow.yml: >> > > - copy & paste from README >> > > - modified Input Ports id so that it matches with the remote NiFi's >> > > input port uuid >> > > - enabled Site-to-Site at the remote NiFi >> > > Started minifi, created a file under /tmp/getfile dir, then confirmed >> > > the file content was sent to the remote NiFi via Site-to-Site >> > > >> > > >> > > >> > > On Mon, Aug 29, 2016 at 5:52 AM, Aldrin Piri <ald...@apache.org> >> wrote: >> > > >> > > Hello Apache NiFi Community, >> > > >> > > I am pleased to be calling this vote for the source release of Apache >> > NiFi >> > > MiNiFi C++, nifi-minifi-cpp-0.0.1. >> > > >> > > The source archive, signature, and digests can be located at: >> > > >> > > Source Archive: >> > > https://dist.apache.org/repos/dist/dev/nifi/nifi- >> > > minifi-cpp/0.0.1/nifi-minifi-cpp-0.0.1-source.tar.gz >> > > GPG armored signature: >> > > https://dist.apache.org/repos/dist/dev/nifi/nifi- >> > > minifi-cpp/0.0.1/nifi-minifi-cpp-0.0.1-source.tar.gz.asc >> > > Source MD5: >> > > https://dist.apache.org/repos/dist/dev/nifi/nifi- >> > > minifi-cpp/0.0.1/nifi-minifi-cpp-0.0.1-source.tar.gz.md5 >> > > Source SHA1: >> > > https://dist.apache.org/repos/dist/dev/nifi/nifi- >> > > minifi-cpp/0.0.1/nifi-minifi-cpp-0.0.1-source.tar.gz.sha1 >> > > Source SHA256: >> > > https://dist.apache.org/repos/dist/dev/nifi/nifi- >> > > minifi-cpp/0.0.1/nifi-minifi-cpp-0.0.1-source.tar.gz.sha256 >> > > >> > > The Git tag is minifi-cpp-0.0.1-RC1 >> > > The Git commit hash is 61f0e450ef6604e7028be38f0335e70713ebdea3 >> > > * https://git-wip-us.apache.org/repos/asf?p=nifi-minifi-cpp. >> > > git;a=commit;h=61f0e450ef6604e7028be38f0335e70713ebdea3 >> > > * https://github.com/apache/nifi-minifi-cpp/commit/ >> > > 61f0e450ef6604e7028be38f0335e70713ebdea3 >> > > >> > > Checksums of nifi-minifi-cpp-0.0.1-source.tar.gz: >> > > MD5: 24121f1ebe3a678d5e2dc84fb8479ef6 >> > > SHA1: 32c1fb584c9bb484c456cdc4f5dfdd9e91e13364 >> > > SHA256: c72046d86a9dc34033fa40ad1b2300f1f7915acd369f763e7fc02095d09b >> b91e >> > > >> > > Release artifacts are signed with the following key: >> > > https://people.apache.org/keys/committer/aldrin >> > > >> > > KEYS file available here: >> > > https://dist.apache.org/repos/dist/release/nifi/KEYS >> > > >> > > 11 issues were closed/resolved for this release: >> > > https://issues.apache.org/jira/secure/ReleaseNote.jspa? >> > > version=12337990&projectId=12319921 >> > > >> > > Release note highlights can be found here: >> > > https://cwiki.apache.org/confluence/display/MINIFI/ >> > > Release+Notes#ReleaseNotes-Versioncpp-0.0.1 >> > > >> > > The vote will be open for 72 hours. >> > > Please download the release candidate and evaluate the necessary items >> > > including checking hashes, signatures, build from source, and test. >> Then >> > > please vote: >> > > >> > > [ ] +1 Release this package as nifi-minifi-cpp-0.0.1 >> > > [ ] +0 no opinion >> > > [ ] -1 Do not release this package because... >> > > >> > > Thanks! >> > > >> > > >> > > >> > >> >> >> >> -- >> Thanks, >> Andrew >> >> Subscribe to my book: Streaming Data <http://manning.com/psaltis> >> <https://www.linkedin.com/pub/andrew-psaltis/1/17b/306> >> twiiter: @itmdata <http://twitter.com/intent/user?screen_name=itmdata> >> > >
