+1 (non-binding) - Verified checksums - Successfully ran mvn clean install, on OS X and Windows Server 2016, with Oracle JDK 1.8.0_111-b14, mvn 3.3.9 - Run example data flows on OS X and Windows
Building and testing on Windows went well without issue. I hope the InvokeScriptedProcessor test failure Aldrin encountered was caused by Java version difference. On Mon, Nov 28, 2016 at 8:05 AM, Yolanda Davis <[email protected]> wrote: > Aldrin, > > I saw the same exception on that test on OS X but it resolved when I > upgraded my version of java (upgraded to 1.8.0_111-b14) > > > On Sun, Nov 27, 2016 at 5:13 PM, Aldrin Piri <[email protected]> wrote: > >> +1, binding >> >> Hashes and signatures looked good. >> Contrib passed >> Builds and functionality were okay on OS X and Linux. >> >> I could not get a successful build on Windows 10 without removing some >> tests. I ran into the item covered in >> https://issues.apache.org/jira/browse/NIFI-2692 from the 1.0 release as >> well as the following in TestInvokeJavascript. This was with JDK >> 1.8.0u77. Will create a ticket to capture but was not reproducible in any >> other environments inclusive of a Windows 7 VM. Removing those tests >> produced a working build in Windows 10. >> >> [main] INFO org.apache.nifi.processors.script.InvokeScriptedProcessor - >> InvokeScriptedProcessor[id=11fe6a03-cb69-4b78-8b74-b16eeacc3710] logger is >> set! logger=org.apache.nifi.util.MockComponentLog@645aa696 >> [main] ERROR org.apache.nifi.processors.script.InvokeScriptedProcessor - >> [InvokeScriptedProcessor[id=11fe6a03-cb69-4b78-8b74-b16eeacc3710]] Unable >> to validate the script Processor: java.lang.ClassCastException: Cannot cast >> jdk.nashorn.internal.objects.NativeArray to java.util.Collection >> java.lang.ClassCastException: Cannot cast >> jdk.nashorn.internal.objects.NativeArray >> to java.util.Collection >> at java.lang.invoke.MethodHandleImpl.newClassCastException( >> MethodHandleImpl.java:361) >> at java.lang.invoke.MethodHandleImpl.castReference( >> MethodHandleImpl.java:356) >> at org.apache.nifi.processor.Processor$$NashornJavaAdapter. >> validate(Unknown >> Source) >> at org.apache.nifi.processors.script.InvokeScriptedProcessor. >> customValidate( >> InvokeScriptedProcessor.java:464) >> at org.apache.nifi.components.AbstractConfigurableComponent.validate( >> AbstractConfigurableComponent.java:126) >> at org.apache.nifi.util.MockProcessContext.validate( >> MockProcessContext.java:226) >> at org.apache.nifi.util.MockProcessContext.assertValid( >> MockProcessContext.java:243) >> at org.apache.nifi.util.StandardProcessorTestRunner.assertValid( >> StandardProcessorTestRunner.java:334) >> at org.apache.nifi.processors.script.TestInvokeJavascript. >> testReadFlowFileContentAndStoreInFlowFileAttribute( >> TestInvokeJavascript.java:59) >> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >> at sun.reflect.NativeMethodAccessorImpl.invoke( >> NativeMethodAccessorImpl.java:62) >> at sun.reflect.DelegatingMethodAccessorImpl.invoke( >> DelegatingMethodAccessorImpl.java:43) >> at java.lang.reflect.Method.invoke(Method.java:497) >> at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall( >> FrameworkMethod.java:50) >> at org.junit.internal.runners.model.ReflectiveCallable.run( >> ReflectiveCallable.java:12) >> at org.junit.runners.model.FrameworkMethod.invokeExplosively( >> FrameworkMethod.java:47) >> at org.junit.internal.runners.statements.InvokeMethod. >> evaluate(InvokeMethod.java:17) >> at org.junit.internal.runners.statements.RunBefores. >> evaluate(RunBefores.java:26) >> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) >> at org.junit.runners.BlockJUnit4ClassRunner.runChild( >> BlockJUnit4ClassRunner.java:78) >> at org.junit.runners.BlockJUnit4ClassRunner.runChild( >> BlockJUnit4ClassRunner.java:57) >> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) >> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) >> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) >> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) >> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) >> at org.junit.internal.runners.statements.RunBefores. >> evaluate(RunBefores.java:26) >> at org.junit.runners.ParentRunner.run(ParentRunner.java:363) >> at org.junit.runner.JUnitCore.run(JUnitCore.java:137) >> at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs( >> JUnit4IdeaTestRunner.java:78) >> at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart( >> JUnitStarter.java:212) >> at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:68) >> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >> at sun.reflect.NativeMethodAccessorImpl.invoke( >> NativeMethodAccessorImpl.java:62) >> at sun.reflect.DelegatingMethodAccessorImpl.invoke( >> DelegatingMethodAccessorImpl.java:43) >> at java.lang.reflect.Method.invoke(Method.java:497) >> at com.intellij.rt.execution.application.AppMain.main(AppMain.java:140) >> >> java.lang.AssertionError: Processor has 1 validation failures: >> 'Validation' validated against >> 'target/test/resources/javascript/test_reader.js' >> is invalid because An error occurred calling validate in the configured >> script Processor. >> >> at org.junit.Assert.fail(Assert.java:88) >> at org.apache.nifi.util.MockProcessContext.assertValid( >> MockProcessContext.java:251) >> at org.apache.nifi.util.StandardProcessorTestRunner.assertValid( >> StandardProcessorTestRunner.java:334) >> at org.apache.nifi.processors.script.TestInvokeJavascript. >> testReadFlowFileContentAndStoreInFlowFileAttribute( >> TestInvokeJavascript.java:59) >> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >> at sun.reflect.NativeMethodAccessorImpl.invoke( >> NativeMethodAccessorImpl.java:62) >> at sun.reflect.DelegatingMethodAccessorImpl.invoke( >> DelegatingMethodAccessorImpl.java:43) >> at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall( >> FrameworkMethod.java:50) >> at org.junit.internal.runners.model.ReflectiveCallable.run( >> ReflectiveCallable.java:12) >> at org.junit.runners.model.FrameworkMethod.invokeExplosively( >> FrameworkMethod.java:47) >> at org.junit.internal.runners.statements.InvokeMethod. >> evaluate(InvokeMethod.java:17) >> at org.junit.internal.runners.statements.RunBefores. >> evaluate(RunBefores.java:26) >> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) >> at org.junit.runners.BlockJUnit4ClassRunner.runChild( >> BlockJUnit4ClassRunner.java:78) >> at org.junit.runners.BlockJUnit4ClassRunner.runChild( >> BlockJUnit4ClassRunner.java:57) >> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) >> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) >> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) >> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) >> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) >> at org.junit.internal.runners.statements.RunBefores. >> evaluate(RunBefores.java:26) >> at org.junit.runners.ParentRunner.run(ParentRunner.java:363) >> at org.junit.runner.JUnitCore.run(JUnitCore.java:137) >> at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs( >> JUnit4IdeaTestRunner.java:78) >> at com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart( >> JUnitStarter.java:212) >> at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:68) >> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >> at sun.reflect.NativeMethodAccessorImpl.invoke( >> NativeMethodAccessorImpl.java:62) >> at com.intellij.rt.execution.application.AppMain.main(AppMain.java:140) >> >> >> Process finished with exit code -1 >> >> >> On Sat, Nov 26, 2016 at 1:14 AM, Joe Witt <[email protected]> wrote: >> >> > +1 (binding). >> > >> > Verified the primary finding from RC1 was addressed. >> > Verified the finding with RAT completion on windows from RC1 was >> addressed. >> > Verified the test timeout issue was improved. >> > >> > Built using a full clean build with contrib check successfully on OSX, >> > Linux, and Windows 10. >> > Built using a parallel build successfully on OSX, Linux, and logged a >> > JIRA for a test failure on Windows 10. >> > >> > Tested application behavior on each system (osx, linux, windows 10) >> > using Chrome, Firefox, and MS Edge. >> > >> > Thanks >> > Joe >> > >> > On Sat, Nov 26, 2016 at 1:11 AM, Joe Witt <[email protected]> wrote: >> > > Hello Apache NiFi Community, >> > > >> > > I am pleased to be calling this vote for the source release of Apache >> > NiFi, >> > > nifi-1.1.0. >> > > >> > > The source release zip and convenience binaries, including signatures >> > > and digests can be found at: >> > > https://dist.apache.org/repos/dist/dev/nifi/1.0.0-rc2/ >> > > >> > > The Git tag is nifi-1.1.0-RC2 >> > > The Git commit hash is f61e42c65e1c2387591ee368c2148cd5bda646bd >> > > * https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit; >> > h=f61e42c65e1c2387591ee368c2148cd5bda646bd >> > > * https://github.com/apache/nifi/commit/f61e42c65e1c2387591ee3 >> > 68c2148cd5bda646bd >> > > >> > > Checksums of nifi-1.1.0-source-release.zip: >> > > MD5: 371fb856d9c3947603239ea98f171f6f >> > > SHA1: 532c2e14e915dfa522254745bbc068aa6620babb >> > > SHA256: dd1d0569f209fd7f179b85a50fe4bf81b3d850c79b13d32cad88982a8234 >> a719 >> > > >> > > Release artifacts are signed with the following key: >> > > https://people.apache.org/keys/committer/joewitt >> > > >> > > KEYS file available here: >> > > https://dist.apache.org/repos/dist/release/nifi/KEYS >> > > >> > > 268 issues were closed/resolved for this release: >> > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?proj >> > ectId=12316020&version=12337875 >> > > >> > > >> > > Release note highlights can be found here: >> > > https://cwiki.apache.org/confluence/display/NIFI/Release+No >> > tes#ReleaseNotes-Version1.1.0 >> > > >> > > The vote will be open for 72 hours. >> > > Please download the release candidate and evaluate the necessary items >> > > including checking hashes, signatures, build from source, and test. >> Then >> > > please vote: >> > > >> > > [ ] +1 Release this package as nifi-1.1.0 >> > > [ ] +0 no opinion >> > > [ ] -1 Do not release this package because... >> > > >> > > Thanks! >> > >> > > > > -- > -- > [email protected] > @YolandaMDavis
