+1 I've made a few contributions and noticed the inconsistent style. I had been trying to match the surrounding style(s), but a consistent style guide/automated style check will be very welcomed. ________________________________________ From: Andre <[email protected]> Sent: Monday, February 6, 2017 10:51:20 PM To: [email protected] Subject: Re: C++ Style Guide
Aldrin, I am also aware of someone trying to use googletest to streamline the creation of cpp test coverage. I believe we may see a PR sometime later this week. Cheers On Tue, Feb 7, 2017 at 8:51 AM, Aldrin Piri <[email protected]> wrote: > Marc, > > I think that makes a lot of sense and certainly would be a +1 for the > effort. > > Would it also make sense to roll in the associated linter [1] and make that > an available target of build process to help identify compliance? > > [1] https://github.com/google/styleguide/tree/gh-pages/cpplint > > On Mon, Feb 6, 2017 at 2:51 PM, Marc <[email protected]> wrote: > > > Hello Everyone, > > > > I'm submitting a few PRs to the MiNiFi CPP project and would like to > > discuss a style guide for the C++ development. I'm partial to Google's > > Style guide: > > > > https://google.github.io/styleguide/cppguide.html > > > > Are there any objections to this? As I make PRs I'd like to make some > > changes in favor of this style guide and wanted some support for or > against > > this. I don't intend on making wholesale changes for the sake of the > style > > guide, but instead will make these changes iteratively with my PRs. > > > > In the future if there is support for it we can create a pre-commit > hook > > to 'beautify the code' with a tool like clang-format or astyle. > > > > Thoughts for/against this style guide? > > > > Thanks, > > Marc > > >
