Sure - I see what you mean, that is a much better approach. I will certainly do that.
On February 9, 2017 at 09:02:05, Koji Kawamura ([email protected]) wrote: Hi Otto, Thanks for reporting this. I personally haven't encountered this issue, but as described here [1], when I opened the directory that the test uses by Mac Finder application, and changed view as icon and move the icon position, then a .DS_Store file was created. I agree with your workaround and I think we should resolve the issue. By looking at the usage of that method, such as DBCPConnectionPool, or JoltTransformJSON, those uses file name filter like this: (dir, name) -> name != null && name.endsWith(".jar") While filtering out specific .DS_Store works, targeting only name ending with .jar looks more generic work around. Would you mind open a JIRA and send a PR? I'd happy to review! Thanks, Koji On Thu, Feb 9, 2017 at 1:20 PM, Otto Fowler <[email protected]> wrote: > If it turns out that this *is* something you would like addressed, I can do > the jira and the PR > > > On February 8, 2017 at 23:13:16, Otto Fowler ([email protected]) > wrote: > > @Test > public void testGetURLsForClasspathWithDirectory() throws > MalformedURLException { > final String jarFilePath = "src/test/resources/TestClassLoaderUtils"; > URL[] urls = ClassLoaderUtils.getURLsForClasspath(jarFilePath, > (dir,name)->name.compareTo(".DS_Store") == 0, false); > assertEquals(2, urls.length); > } > > > resolves the issue, and I am able to build everything. > > > On February 8, 2017 at 22:39:53, Otto Fowler ([email protected]) > wrote: > > Hi, > > I’m trying to build master on Mac OS X, following the instructions from the > site linked in the README.md. > > My build is failing because the unit test: > testGetURLsForClasspathWithDirectory > in TestClassLoaderUtils. > > It is trying to URLs from a directory, and is expecting 2, but gets 3, > because the DS_STORE is detected and has an url built and returned for it. > > The test does not pass in a FileNamesFilter, which could be used to filter > these files out I suppose. > > I am wondering if anyone is building successfully on Mac OS X?
