If it doesn’t pass on Windows, does it make sense to add a profile trigger to avoid running the check entirely if the OS is Windows?
Andy LoPresto [email protected] [email protected] PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69 > On May 8, 2017, at 7:19 AM, Joe Witt <[email protected]> wrote: > > Yep agreed. Can do a jira sweep based on vite thread feedback. > > On May 8, 2017 10:14 AM, "Andrew Psaltis" <[email protected]> wrote: > >> Cool -- not sure if it is worth calling that out in next Release Guideline, >> as it may trip up others or most likely myself again :) >> >> On Mon, May 8, 2017 at 9:54 AM, Joe Witt <[email protected]> wrote: >> >>> Rat check has never worked on windows and is flakey in parallel builds at >>> best. >>> >>> On May 8, 2017 9:05 AM, "Andrew Psaltis" <[email protected]> >> wrote: >>> >>>> +0 (non-binding) -- failed building on Windows 10 using mvn clean >> install >>>> -Pcontrib-check -DskipTests (skipped test as build with tests failed) >>>> >>>> Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426; >>>> 2017-04-03T15:39:06-04:00) >>>> Maven home: c:\tools\apache-maven-3.5.0\bin\.. >>>> Java version: 1.8.0_131, vendor: Oracle Corporation >>>> Java home: C:\Program Files\Java\jdk1.8.0_131\jre >>>> Default locale: en_US, platform encoding: Cp1252 >>>> OS name: "windows 10", version: "10.0", arch: "amd64", family: >> "windows" >>>> >>>> Build failed with RAT check against nifi-poi-processors. Not sure if >>> this >>>> is expected or not. Details of rat.txt output are: >>>> >>>> >>>> ***************************************************** >>>> Summary >>>> ------- >>>> Generated at: 2017-05-08T08:22:12-04:00 >>>> Notes: 0 >>>> Binaries: 2 >>>> Archives: 0 >>>> Standards: 6 >>>> >>>> Apache Licensed: 5 >>>> Generated Documents: 0 >>>> >>>> JavaDocs are generated and so license header is optional >>>> Generated files do not required license headers >>>> >>>> 1 Unknown Licenses >>>> >>>> ******************************* >>>> >>>> Unapproved licenses: >>>> >>>> >>>> C:/Users/apsal/Downloads/nifi-1.2.0/nifi-nar-bundles/nifi- >>>> poi-bundle/nifi-poi-processors/src/test/resources/Unsupported.xls >>>> >>>> ******************************* >>>> >>>> Archives: >>>> >>>> ***************************************************** >>>> Files with Apache License headers will be marked AL >>>> Binary files (which do not require AL headers) will be marked B >>>> Compressed archives will be marked A >>>> Notices, licenses etc will be marked N >>>> AL >>>> C:/Users/apsal/Downloads/nifi-1.2.0/nifi-nar-bundles/nifi- >>>> poi-bundle/nifi-poi-processors/pom.xml >>>> AL >>>> C:/Users/apsal/Downloads/nifi-1.2.0/nifi-nar-bundles/nifi- >>>> poi-bundle/nifi-poi-processors/src/main/java/org/ >>>> apache/nifi/processors/poi/ConvertExcelToCSVProcessor.java >>>> AL >>>> C:/Users/apsal/Downloads/nifi-1.2.0/nifi-nar-bundles/nifi- >>>> poi-bundle/nifi-poi-processors/src/main/resources/ >>>> META-INF/services/org.apache.nifi.processor.Processor >>>> AL >>>> C:/Users/apsal/Downloads/nifi-1.2.0/nifi-nar-bundles/nifi- >>>> poi-bundle/nifi-poi-processors/src/test/java/org/ >>>> apache/nifi/processors/poi/ConvertExcelToCSVProcessorTest.java >>>> B >>>> C:/Users/apsal/Downloads/nifi-1.2.0/nifi-nar-bundles/nifi- >>>> poi-bundle/nifi-poi-processors/src/test/resources/ >> CollegeScorecard.xlsx >>>> AL >>>> C:/Users/apsal/Downloads/nifi-1.2.0/nifi-nar-bundles/nifi- >>>> poi-bundle/nifi-poi-processors/src/test/resources/logback-test.xml >>>> B >>>> C:/Users/apsal/Downloads/nifi-1.2.0/nifi-nar-bundles/nifi- >>>> poi-bundle/nifi-poi-processors/src/test/resources/TwoSheets.xlsx >>>> !????? >>>> C:/Users/apsal/Downloads/nifi-1.2.0/nifi-nar-bundles/nifi- >>>> poi-bundle/nifi-poi-processors/src/test/resources/Unsupported.xls >>>> >>>> ***************************************************** >>>> Printing headers for files without AL header... >>>> >>>> >>>> ============================================================ >> =========== >>>> ==C:/Users/apsal/Downloads/nifi-1.2.0/nifi-nar-bundles/ >>>> nifi-poi-bundle/nifi-poi-processors/src/test/resources/Unsupported.xls >>>> ============================================================ >> =========== >>>> ÐÏ?ࡱ?á????????????????>???þÿ >>>> ?????????????????1???????????þÿÿÿ????þÿÿÿ????0??? >>>> ÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿ >>>> ÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿ >>>> ÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿ >>>> ÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿ >>>> ÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿ >>>> ÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿ >>>> ÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿÿ >> ÿÿÿÿÿÿÿÿÿÿÿÿ >>>> ???????£DÍ?Á???????á???°?Á?????â???\?p????james >>>> >>>> >>>> B???°?a?????À???=?????œ???????????????????????¯?????¼?????=? >>>> ??????R“!8???????X?@???????????"???????????·?????Ú?????1??? >>>> Ü???????????????C?a?l?i?b?r?i?1???Ü???????????????C?a?l?i?b? >>>> r?i?1???Ü???????????????C?a?l?i?b?r?i?1???Ü???????????????C? >>>> a?l?i?b?r?i?1???Ü???????????????C?a?l?i?b?r?i?1?*?h???6????????? >>>> ?C?a?l?i?b?r?i? >>>> ?L?i?g?h?t?1???,???6?¼?????????C?a?l?i?b?r?i?1???????6?¼???? >>>> ?????C?a?l?i?b?r?i?1???Ü???6?¼?????????C?a?l?i?b?r?i?1???Ü?? >>>> ?????????????C?a?l?i?b?r?i?1???Ü???????????????C?a?l?i?b?r? >>>> i?1???Ü???<???????????C?a?l?i?b?r?i?1???Ü???>???????????C?a? >>>> l?i?b?r?i?1???Ü?????¼?????????C?a?l?i?b?r?i?1???Ü???4?¼????? >>>> ????C?a?l?i?b?r?i?1???Ü???4???????????C?a?l?i?b?r?i?1???Ü??? >>>> ?¼?????????C?a?l?i?b?r?i?1???Ü??? >>>> ???????????C?a?l?i?b?r?i?1???Ü???????????????C?a?l?i?b?r?i? >>>> 1???Ü?????¼?????????C?a?l?i?b?r?i?1???Ü??? >>>> ???????????C?a?l?i?b?r?i??????????"$"#,##0_);\("$"#,##0\)??! >>>> ??????"$"#,##0_);[Red]\("$"#,##0\)??"??????"$"#,##0.00_);\(" >>>> $"#,##0.00\)??'???"??"$"#,##0.00_);[Red]\("$"#,##0.00\)??7?*?2??_("$"* >>>> #,##0_);_("$"* \(#,##0\);_("$"* "-"_);_(@_)??.?)?)??_(* #,##0_);_(* >>>> \(#,##0\);_(* "-"_);_(@_)????,?:??_("$"* #,##0.00_);_("$"* >>>> \(#,##0.00\);_("$"* "-"??_);_(@_)??6?+?1??_(* #,##0.00_);_(* >>>> \(#,##0.00\);_(* "-"??_);_(@_)à???????õÿ ???????????À à???????õÿ >>>> ??ô????????À à???????õÿ ??ô????????À à???????õÿ ??ô????????À à???????õÿ >>>> ??ô????????À à???????õÿ ??ô????????À à???????õÿ ??ô????????À à???????õÿ >>>> ??ô????????À à???????õÿ ??ô????????À à???????õÿ ??ô????????À à???????õÿ >>>> ??ô????????À à???????õÿ ??ô????????À à???????õÿ ??ô????????À à???????õÿ >>>> ??ô????????À à???????õÿ ??ô????????À à????????? ???????????À à???????õÿ >>>> ??´????????Ÿ à???????õÿ ??´????????¯ à???????õÿ ??´????????‰ à???????õÿ >>>> ??´????????š à???????õÿ ??´????????› à???????õÿ ??´????????ª à???????õÿ >>>> ??´????????¬ à???????õÿ ??´????????¯ à???????õÿ ??´????????– à???????õÿ >>>> ??´????????« à???????õÿ ??´????????¬ à???????õÿ ??´????????« à???????õÿ >>>> ??´????????± à???????õÿ ??´????????¯ à???????õÿ ??´????????– à???????õÿ >>>> ??´????????« à???????õÿ ??´????????¬ à???????õÿ ??´????????¹ à???????õÿ >>>> ??´????????¾ à???????õÿ ??´????????µ à???????õÿ ??´????????· à???????õÿ >>>> ??´????????³ à???????õÿ ??´????????± à???????õÿ ??´????????¹ à???????õÿ >>>> ??´???????? à???????õÿ ??”??—?—???– à???????õÿ ??”ff¿?¿???· à?????+?õÿ >>>> ??ø????????À à?????)?õÿ ??ø????????À à?????,?õÿ ??ø????????À à?????*?õÿ >>>> ??ø????????À à???????õÿ ??ô????????À à??? >>>> ???õÿ ??´????????ª à???????õÿ ??Ô?P??????À à???????õÿ ??Ô?P??????À à??? >>>> ???õÿ >>>> ??Ô? ??€???À à??? ???õÿ ??ô????????À à??? >>>> ???õÿ ??”??—?—???¯ à???????õÿ ??Ô?`??????À à???????õÿ ??´????????« >>>> à???????õÿ ??œ????????š à???????õÿ ??”??¿?¿???– à????? ?õÿ ??ø????????À >>>> à???????õÿ ??ô????????À à???????õÿ ??Ô?a??>???À à???????õÿ ??ô????????À >>>> à????????? ??H????????? |???|???????????????q¼PA}?-?}? >> ?????????????????? >>>> ???????????00\);_(*?????}?-?}??????????????????? >>>> ???????????00\);_(*?????}?-?}??????????????????? >>>> ???????????00\);_(*?????}?-?}??????????????????? >>>> ???????????00\);_(*?????}?-?}??????????????????? >>>> ???????????00\);_(*?????}?-?}??????????????????? >>>> ???????????00\);_(*?????}?-?}??????????????????? >>>> ???????????00\);_(*?????}?-?}??????????????????? >>>> ???????????00\);_(*?????}?-?}??????????????????? >>>> ???????????00\);_(*?????}?-?}????????????? ????? >>>> ???????????00\);_(*?????}?-?}????????????? >>>> ????? >>>> ???????????00\);_(*?????}?-?}??????????????????? >>>> ???????????00\);_(*?????}?-?}??????????????????? >>>> ???????????00\);_(*?????}?-?}????????????? >>>> ????? >>>> ???????????00\);_(*?????}?-?}??????????????????? >>>> ???????????00\);_(*?????}?-?}??????????????????? >>>> ???????????00\);_(*?????}?-?}?????????????+????? >>>> ???????????00\);_(*?????}?-?}?????????????,????? >>>> ???????????00\);_(*?????}?-?}?????????????-????? >>>> ???????????00\);_(*?????}?-?}?????????????.????? >>>> ???????????00\);_(*?????}?-?}?????????????:????? >>>> ???????????00\);_(*?????}?-?}?????????????;????? >>>> ???????????00\);_(*?????}?A?}?????????????1????? >>>> ???????????00\);_(*?????????????????;_(@_) }?A?}?????????????2????? >>>> ???????????00\);_(*???????????ÿ?????;_(@_) }?A?}?????????????3????? >>>> ???????????00\);_(*???????????23????;_(@_) }?-?}?????????????4????? >>>> ???????????00\);_(*?????}?A?}?????????????0????? >>>> ????????a?ÿ00\);_(*?????????????ÆïÎÿ;_(@_) }?A?}?????????????(????? >>>> ???????œ??ÿ00\);_(*?????????????ÿÇÎÿ;_(@_) }?A?}?????????????7????? >>>> ???????œW?ÿ00\);_(*?????????????ÿëœÿ;_(@_) }?‘?}?????????????5????? >>>> ?????????vÿ00\);_(*?????????????ÿÌ™ÿ;_(@_) ???????? ÿ >> ???????? ÿ >>>> ??????? ÿ???????? >>>> ??????? ÿ????????}?‘?}?????????????9????? >>>> ??????????ÿ00\);_(*?????????????òòòÿ;_(@_) ???????????ÿ >>>> ???????????ÿ ??????????ÿ???????? >>>> ??????????ÿ????????}?‘?}?????????????)????? >>>> ???????ú}?ÿ00\);_(*?????????????òòòÿ;_(@_) ???????? ÿ >> ???????? ÿ >>>> ??????? ÿ???????? >>>> ??????? ÿ????????}?A?}?????????????6????? >>>> ???????ú}?ÿ00\);_(*?????????????ÿ€?ÿ;_(@_) }?‘?}?????????????*????? >>>> ???????????00\);_(*?????????????¥¥¥ÿ;_(@_) ???????????ÿ >>>> ???????????ÿ ??????????ÿ???????? >>>> ??????????ÿ????????}?-?}?????????????=????? >>>> ???????ÿ??ÿ00\);_(*?????}?‘?}?????????????8????? >>>> ???????????00\);_(*?????????????ÿÿÌÿ;_(@_) ????????²²²ÿ >>>> ????????²²²ÿ ???????²²²ÿ???????? >>>> ???????²²²ÿ????????}?-?}?????????????/????? >>>> ??????? ÿ00\);_(*?????}?U?}?????????????<????? >>>> ???????????00\);_(*?????????????????;_(@_) ???????????? >>>> }?A?}?????????????"????? >>>> >>>> >>>> >>>> On Mon, May 8, 2017 at 2:12 AM, Andy LoPresto < >>> [email protected]> >>>> wrote: >>>> >>>>> Joey, >>>>> >>>>> I am curious about the test failure. That is the test I refactored >> due >>> to >>>>> the POSIX attribute issue failing on Windows right before the RC. It >>>> passed >>>>> when I built on Linux so if you can open a Jira or at least provide >> me >>>> with >>>>> a stack trace and any steps to make it reproducible, I would >> appreciate >>>> it. >>>>> >>>>> Andy LoPresto >>>>> [email protected] >>>>> [email protected] >>>>> PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 BACE 3C6E F65B 2F7D EF69 >>>>> >>>>>> On May 7, 2017, at 22:17, Joey Frazee <[email protected]> >>> wrote: >>>>>> >>>>>> +1 (non-binding) >>>>>> >>>>>> - Verified signature, checksums and commit id >>>>>> - Successfully ran `mvn clean install -Pcontrib-check` on OS X >>> 10.12.4 >>>>> with Oracle JDK 1.8.0_121 and Amazon Linux with OpenJDK 1.8.0_121 >>>>>> - Successfully ran `mvn clean install -DskipTests` on Docker >>>>> maven:latest with OpenJDK 1.8.0_121 but CryptoUtilsTest. >>>>> testShouldNotValidateUnreadableFileBasedKeyProvider always failed >> with >>>>> !unreadableKeyProviderIsValid >>>>>> - Built RPM with `mvn -T 4.0C clean install -Prpm,generateArchives >>>>> -DskipTests` and tested RPM install >>>>>> - Tested GenerateTableFetch and QueryDatabaseTable with MS SQL 2008 >>>>> [NIFI-3585], among other flows. >>>>>> >>>>>>> On May 5, 2017, at 9:07 PM, Bryan Bende <[email protected]> >> wrote: >>>>>>> >>>>>>> Hello, >>>>>>> >>>>>>> I am pleased to be calling this vote for the source release of >>> Apache >>>>>>> NiFi nifi-1.2.0 (RC2). >>>>>>> >>>>>>> The source zip, including signatures, digests, etc. can be found >> at: >>>>>>> https://repository.apache.org/content/repositories/ >>> orgapachenifi-1104 >>>>>>> >>>>>>> The Git tag is nifi-1.2.0-RC2 >>>>>>> The Git commit ID is 3a605af8e0ac024fb0ba67262d49dab2727b2576 >>>>>>> https://git-wip-us.apache.org/repos/asf?p=nifi.git;a=commit;h= >>>>> 3a605af8e0ac024fb0ba67262d49dab2727b2576 >>>>>>> >>>>>>> Checksums of nifi-1.2.0-source-release.zip: >>>>>>> MD5: 90e298a9e23a9dab65358daddd8b5990 >>>>>>> SHA1: e138941f576bdb1dff17df6674c19ffae3ef6719 >>>>>>> SHA256: c18398800c435dabff9f45ec55a450 >>> ca78c3c1aec222aa295c0e2057912f >>>>> eeb6 >>>>>>> >>>>>>> Release artifacts are signed with the following key: >>>>>>> https://people.apache.org/keys/committer/bbende.asc >>>>>>> >>>>>>> KEYS file available here: >>>>>>> https://dist.apache.org/repos/dist/release/nifi/KEYS >>>>>>> >>>>>>> 381 issues were closed/resolved for this release: >>>>>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa? >>>>> projectId=12316020&version=12338432 >>>>>>> >>>>>>> Release note highlights can be found here: >>>>>>> https://cwiki.apache.org/confluence/display/NIFI/ >>>>> Release+Notes#ReleaseNotes-Version1.2.0 >>>>>>> >>>>>>> The vote will be open for 72 hours. >>>>>>> Please download the release candidate and evaluate the necessary >>> items >>>>>>> including checking hashes, signatures, build >>>>>>> from source, and test. The please vote: >>>>>>> >>>>>>> [ ] +1 Release this package as nifi-1.2.0 >>>>>>> [ ] +0 no opinion >>>>>>> [ ] -1 Do not release this package because because... >>>>>> >>>>> >>>> >>>> >>>> >>>> -- >>>> Thanks, >>>> Andrew >>>> >>>> Subscribe to my book: Streaming Data <http://manning.com/psaltis> >>>> <https://www.linkedin.com/pub/andrew-psaltis/1/17b/306> >>>> twiiter: @itmdata <http://twitter.com/intent/user?screen_name=itmdata> >>>> >>> >> >> >> >> -- >> Thanks, >> Andrew >> >> Subscribe to my book: Streaming Data <http://manning.com/psaltis> >> <https://www.linkedin.com/pub/andrew-psaltis/1/17b/306> >> twiiter: @itmdata <http://twitter.com/intent/user?screen_name=itmdata> >>
signature.asc
Description: Message signed with OpenPGP using GPGMail
