Andy, I believe the correct course of action is to resolve the code so that we don't have duplicate code. This was found quite some time ago in the original code that was copied, but unfortunately I wasn't aware the error was propagated. I've resolved the duplicate code, and hence the error in a commit I have out of necessity, but that commit relies on some other changes to be merged. I could break it out, but since this in master and not a release I'm inclined to wait on some additional testing with I"m currently doing. As a result we can push it under MINIFI-376 and I'll simply resolve conflicts later. I should be able to task switch soon if you don't have cycles. Thanks!
On Wed, Aug 16, 2017 at 10:38 AM, Andy Christianson < [email protected]> wrote: > OK. I created MINIFI-376 [1] to track the issue. I take it the fix is to > remove the references? Do you recommend for this to be done in a bug fix > branch, or will it be taken care of in one of your upcoming merges? > > [1] https://issues.apache.org/jira/browse/MINIFI-376 > > Regards, > > Andy I.C. > > On 8/16/17, 10:36 AM, "Marc" <[email protected]> wrote: > > Andy, > In a branch I've been working on, I happened upon those ( > curlbuild.h > and easy.h which I believe are unnecessary ) , which were removed > elsewhere > but apparently I didn't see them here due to copy/paste of some code > and > removed them without issue. > > On Wed, Aug 16, 2017 at 10:30 AM, Andy Christianson < > [email protected]> wrote: > > > MiNiFi cpp devs, > > > > Very recently I started getting this unexpected compilation error in > the > > ‘make docker’ target. I double-checked the packages we are > installing in > > the Dockerfile, and it does include curl-dev, so I’m confused why > we’d be > > seeing this. Is it perhaps a curl version issue? > > > > [ 3%] Performing build step for 'jsoncpp_project' > > Scanning dependencies of target jsoncpp_lib_static > > [ 25%] Building CXX object src/lib_json/CMakeFiles/ > > jsoncpp_lib_static.dir/json_reader.cpp.o > > [ 50%] Building CXX object src/lib_json/CMakeFiles/ > > jsoncpp_lib_static.dir/json_value.cpp.o > > [ 75%] Building CXX object src/lib_json/CMakeFiles/ > > jsoncpp_lib_static.dir/json_writer.cpp.o > > [100%] Linking CXX static library libjsoncpp.a > > [100%] Built target jsoncpp_lib_static > > [ 3%] Performing install step for 'jsoncpp_project' > > [100%] Built target jsoncpp_lib_static > > Install the project... > > -- Install configuration: "Release" > > -- Installing: /opt/minifi/build/jsoncpp/lib/pkgconfig/jsoncpp.pc > > -- Installing: /opt/minifi/build/jsoncpp/lib/libjsoncpp.a > > -- Installing: /opt/minifi/build/jsoncpp/include/json/allocator.h > > -- Installing: /opt/minifi/build/jsoncpp/include/json/assertions.h > > -- Installing: /opt/minifi/build/jsoncpp/include/json/autolink.h > > -- Installing: /opt/minifi/build/jsoncpp/include/json/config.h > > -- Installing: /opt/minifi/build/jsoncpp/include/json/features.h > > -- Installing: /opt/minifi/build/jsoncpp/include/json/forwards.h > > -- Installing: /opt/minifi/build/jsoncpp/include/json/json.h > > -- Installing: /opt/minifi/build/jsoncpp/include/json/reader.h > > -- Installing: /opt/minifi/build/jsoncpp/include/json/value.h > > -- Installing: /opt/minifi/build/jsoncpp/include/json/version.h > > -- Installing: /opt/minifi/build/jsoncpp/include/json/writer.h > > [ 3%] Completed 'jsoncpp_project' > > [ 3%] Built target jsoncpp_project > > Scanning dependencies of target minifi > > [ 3%] Building CXX object libminifi/CMakeFiles/minifi. > > dir/src/core/logging/LoggerConfiguration.cpp.o > > [ 4%] Building CXX object libminifi/CMakeFiles/minifi. > > dir/src/io/AtomicEntryStream.cpp.o > > [ 4%] Building CXX object libminifi/CMakeFiles/minifi. > > dir/src/io/BaseStream.cpp.o > > [ 5%] Building CXX object libminifi/CMakeFiles/minifi. > > dir/src/io/CRCStream.cpp.o > > [ 5%] Building CXX object libminifi/CMakeFiles/minifi. > > dir/src/io/ClientSocket.cpp.o > > [ 6%] Building CXX object libminifi/CMakeFiles/minifi. > > dir/src/io/DataStream.cpp.o > > [ 6%] Building CXX object libminifi/CMakeFiles/minifi. > > dir/src/io/EndianCheck.cpp.o > > [ 6%] Building CXX object libminifi/CMakeFiles/minifi. > > dir/src/io/FileStream.cpp.o > > [ 7%] Building CXX object libminifi/CMakeFiles/minifi. > > dir/src/io/Serializable.cpp.o > > [ 7%] Building CXX object libminifi/CMakeFiles/minifi. > > dir/src/io/StreamFactory.cpp.o > > [ 8%] Building CXX object libminifi/CMakeFiles/minifi. > > dir/src/io/tls/TLSSocket.cpp.o > > [ 8%] Building CXX object libminifi/CMakeFiles/minifi. > > dir/src/core/controller/ControllerServiceNode.cpp.o > > [ 9%] Building CXX object libminifi/CMakeFiles/minifi. > > dir/src/core/controller/ControllerServiceProvider.cpp.o > > [ 9%] Building CXX object libminifi/CMakeFiles/minifi. > > dir/src/core/controller/StandardControllerServiceNode.cpp.o > > [ 9%] Building CXX object libminifi/CMakeFiles/minifi. > > dir/src/controllers/SSLContextService.cpp.o > > [ 10%] Building CXX object libminifi/CMakeFiles/minifi. > > dir/src/core/ClassLoader.cpp.o > > [ 10%] Building CXX object libminifi/CMakeFiles/minifi.dir/src/core/ > > ConfigurableComponent.cpp.o > > [ 11%] Building CXX object libminifi/CMakeFiles/minifi.dir/src/core/ > > ConfigurationFactory.cpp.o > > In file included from /opt/minifi/libminifi/include/ > > RemoteProcessorGroupPort.h:26:0, > > from /opt/minifi/libminifi/include/ > > core/FlowConfiguration.h:23, > > from /opt/minifi/libminifi/include/ > > core/ConfigurationFactory.h:22, > > from /opt/minifi/libminifi/src/ > > core/ConfigurationFactory.cpp:25: > > /opt/minifi/libminifi/include/utils/HTTPUtils.h:26:28: fatal error: > > curl/curlbuild.h: No such file or directory > > #include <curl/curlbuild.h> > > ^ > > compilation terminated. > > make[2]: *** [libminifi/CMakeFiles/minifi.dir/build.make:471: > > libminifi/CMakeFiles/minifi.dir/src/core/ConfigurationFactory.cpp.o] > > Error 1 > > make[1]: *** [CMakeFiles/Makefile2:1884: > libminifi/CMakeFiles/minifi.dir/all] > > Error 2 > > make: *** [Makefile:163: all] Error 2 > > > > Regards, > > > > Andy I.C. > > > > >
