MiNiFi - C++ Devs:
On an earlier commit, I added the following to the root CMakeLists.txt:
# Enable asan in DEBUG for compatibility with civet
set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -fsanitize=address")
This was, as stated in the comment, to address a compatibility issue when
compiling in DEBUG where civet would fail to link.
On more recent dev toolchains (devtoolset-6 SCL CentOS/GCC 6.3), this results
in extremely verbose and unhelpful output during test runs. While I am not
opposed to using these tools to detect legitimate memory leaks, as it stands
currently the setting is more of a detriment to the development process. I
think that we should either only turn this on when we deliberately intend to
analyze memory usage, or possibly create additional unit tests to detect memory
leaks.
In the meantime, I think we should remove the statement from our CMakeLists.txt
and disable it in the CMakeLists.txt for civet as well.
I would like to hear additional feedback from the development community to see
if we have consensus on this change.
Regards,
Andy I.C.
