Yep probably best. If your processor and its typical usage context could be susceptible to having a connection of only penalized flowfiles in front then if the session.get() call returns null then for that case a call to yield would be nice.
We should also do something so you don't have to :) Thanks On Fri, Dec 22, 2017 at 2:34 PM, Oleksi Derkatch <[email protected]> wrote: > Thanks. > > > We'll keep an eye on that ticket. In the meantime, I think we'll probably > manually yield the processors to save system resources. > > > > ____________________________________________________________ > _____________________________________________ > [image: 1496944291439_image001.png] > Oleksi Derkatch | Software Engineer > > 7 Father David Bauer Drive, Suite 201 > <https://maps.google.com/?q=7+Father+David+Bauer+Drive,+Suite+201%C2%A0%0D+%7C%C2%A0+Waterloo,+ON,+Canada,+N2L+0A2&entry=gmail&source=g> > | Waterloo, ON, Canada, N2L 0A2 > <https://maps.google.com/?q=7+Father+David+Bauer+Drive,+Suite+201%C2%A0%0D+%7C%C2%A0+Waterloo,+ON,+Canada,+N2L+0A2&entry=gmail&source=g> > > +1 519 594 0940 ext.212 <(519)%20594-0940> | +1 844 527 6748 > <(844)%20527-6748> l www.vitalimages.com > ____________________________________________________________ > _____________________________________________ > > > > ------------------------------ > *From:* Michael Moser <[email protected]> > *Sent:* Friday, December 22, 2017 2:29:56 PM > *To:* [email protected] > *Subject:* Re: Penalized FlowFiles still cause Processor Invocations > > This behavior is known and there is an open JIRA ticket [1] for it. It's > not great for the processor's onTrigger() to be continually called without > a flowfile, but it's also not a great user experience to do nothing and > show 0 tasks executed, which leaves the end user with no idea why the > processor isn't working. The current behavior is likely the best choice of > the two, until some good UI notification can be built as mentioned in the > ticket. > > regards, > -- Mike > > [1] - https://issues.apache.org/jira/browse/NIFI-767 > > > On Fri, Dec 22, 2017 at 1:44 PM, Bryan Bende <[email protected]> wrote: > > > Hello, > > > > Does your processor happen to have a @TriggerWhenEmpty annotation on it? > > > > That would cause it to always execute regardless of what is in the queue, > > so just wanted to rule that out. > > > > Thanks, > > > > Bryan > > > > > > On Fri, Dec 22, 2017 at 12:45 PM, Oleksi Derkatch < > > [email protected] > > > wrote: > > > > > Hi, > > > > > > > > > I've noticed that if the every FlowFile in a queue is penalized, I see > > > constant invocations on the processor's onTrigger() method, despite the > > > queue being "effectively" empty. This seems to cause millions of > > > invocations of the processor that don't result in useful work. > > > > > > > > > Am I understanding the situation correctly? Has anyone ever considered > > > changing this behaviour so that we don't have all these calls to > > onTrigger > > > when the queue only contains penalized flow files? > > > > > > > > > Of course, we can update our Processors to just yield() when they get > > > called with a null flow file, but this seems like a good thing for the > > > engine to handle automatically. > > > > > > > > > ____________________________________________________________ > > > _____________________________________________ > > > [image: 1496944291439_image001.png] > > > Oleksi Derkatch | Software Engineer > > > > > > 7 Father David Bauer Drive, Suite 201 > <https://maps.google.com/?q=7+Father+David+Bauer+Drive,+Suite+201&entry=gmail&source=g> > > > <https://maps.google.com/?q=7+Father+David+Bauer+Drive,+ > > Suite+201%C2%A0%0D+%7C%C2%A0+Waterloo,+ON,+Canada,+N2L+0A2& > > entry=gmail&source=g> > > > | Waterloo, ON, Canada, N2L 0A2 > > > <https://maps.google.com/?q=7+Father+David+Bauer+Drive,+ > > Suite+201%C2%A0%0D+%7C%C2%A0+Waterloo,+ON,+Canada,+N2L+0A2& > > entry=gmail&source=g> > > > > > > +1 519 594 0940 ext.212 <(519)%20594-0940> <(519)%20594-0940> | +1 > 844 527 6748 <(844)%20527-6748> > > > <(844)%20527-6748> l www.vitalimages.com > > > ____________________________________________________________ > > > _____________________________________________ > > > > > > > > > > > > > > > Notice - Confidential Information The information in this communication > > > and any attachments is strictly confidential and intended only for the > > use > > > of the individual(s) or entity(ies) named above. If you are not the > > > intended recipient, any dissemination, distribution, copying or other > use > > > of the information contained in this communication and/or any > attachment > > is > > > strictly prohibited. If you have received this communication in error, > > > please first notify the sender immediately and then delete this > > > communication from all data storage devices and destroy all hard > copies. > > > > > >
