-1 binding

Signatures, hashes, etc look right. Build was good and the demo application
started up just fine. The demo application did load a little slowly so we
may want to file a JIRA to improve this in the future.

However, it appears that the version bump only happened in the package.json
and not the package-lock.json. Because of this, the built artifacts that
ended up in the node_modules had a version of 0.0.0 (not 0.1.0). It may
make sense to render this version in the demo application to prevent this
in the future. There's an added benefit that we'd also know what version of
nifi-fds was being shown.

Matt

On Fri, Jun 8, 2018 at 8:03 PM, Scott Aslan <[email protected]> wrote:

> Hello,
>
>
> I am pleased to be calling this vote for the source release of Apache
>
> NiFi Flow Design System 0.1.0.
>
>
> The source zip, including signatures, etc. can be found at:
>
> https://dist.apache.org/repos/dist/dev/nifi/nifi-fds/nifi-fds-0.1.0/
>
>
> The Git tag is nifi-fds-0.1.0-RC1
>
> The Git commit ID is 35423f267de0755087a274ece79c81ef1a4ee641
>
> https://git-wip-us.apache.org/repos/asf?p=nifi-fds.git;a=commit;h=
> 35423f267de0755087a274ece79c81ef1a4ee641
>
>
> Checksums of nifi-fds-0.1.0-source-release.zip:
>
> SHA1: 389b7bda654cfb9a79efa5f893eb37b9f73caaf5
>
> SHA256: b42de408e797df859ab8e11e39bd717c996df775179bfae82bf4392bb346a135
>
> SHA512:
> 3b1cca1d5c3cd1786fb54deaa9e9761feb1b8bd2b365658ecef302ba617d
> d3fe66766513d76ad8686ce7f87a25d6d6152ccdae1bf2dfb3d5dba3e352d53a4122
>
>
> Release artifacts are signed with the following key:
>
> https://people.apache.org/keys/committer/scottyaslan.asc
>
>
> KEYS file available here:
>
> https://dist.apache.org/repos/dist/release/nifi/KEYS
>
>
> 7 issues were closed/resolved for this release:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12316020&version=12343357
>
>
> Release note highlights can be found here:
>
> https://cwiki.apache.org/confluence/display/NIFI/
> Release+Notes#ReleaseNotes-NiFiFlowDesignSystem0.1.0
>
>
> The vote will be open for 72 hours.
>
>
> Please download the release candidate and evaluate the necessary items
>
> including checking hashes, signatures, build from source, and test.
>
>
> The please vote:
>
>
> [ ] +1 Release this package as nifi-fds-0.1.0
>
> [ ] +0 no opinion
>
> [ ] -1 Do not release this package because...
>

Reply via email to